[nodejs] enable rc sampling tests

[ida613]

Motivation

To enable some nodejs tests for ci, since I'm having trouble running them locally

Changes

Workflow

1. ⚠️ Create your PR as draft ⚠️
2. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
3. Mark it as ready for review
   • Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
   • Framework is modified, or non obvious usage of it -> get a review from R&P team

:rocket: Once your PR is reviewed, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

• [ ] Relevant label (run-parametric-scenario, run-profiling-scenario...) are presents
• [ ] If PR title starts with [<language>], double-check that only <language> is impacted by the change
• [ ] No system-tests internal is modified. Otherwise, I have the approval from R&P team
• [ ] CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
• [ ] A docker base image is modified?
  • [ ] the relevant build-XXX-image label is present
• [ ] A scenario is added (or removed)?
  • [ ] Get a review from R&P team

[ida613]

The change is ok, but if you want to merge, could you change the PR description and title? If you don't want to merge it, please change it to draft

How do you want me to change PR description and title?

Something that describe the changes that you want to merge.

[simon-id]

that looks like you're trying to enable some tests in dd-trace-js CI ? if that's the case please put the PR in draft

[ida613]

that looks like you're trying to enable some tests in dd-trace-js CI ? if that's the case please put the PR in draft

I put it on draft, but why are we doing this?

[cbeauchesne]

Hi @ida613 ,

We receive a lot of PR, and all of them need to be reviewed, and depending the change, lot of people are able to review it. In consequence, this repo is in the watchlist of lot of people, and any PR causes lot of github nitifications.

By setting PR as draft, it tells to everybody who is potential reviewers that your PR is a work in progress, and does requires yet any attention.

As soon as it's ready, you can set it as normal PR, ready for review, and it'll get the review.

How do you want me to change PR description and title?

You can edit title and PR description with edit buttons. I agree with Roberto that the current title and description does not makes very clear if this PR is only a test, or if you plan to merge it.