system-tests icon indicating copy to clipboard operation
system-tests copied to clipboard

Use last version of opentracing-contrib/nginx-opentracing

Open cbeauchesne opened this issue 1 year ago • 2 comments

Motivation

Per title

Changes

Use good asset from opentracing-contrib/nginx-opentracing

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

:rocket: Once your PR is reviewed, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • [ ] Relevant label (run-parametric-scenario, run-profiling-scenario...) are presents
  • [ ] No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • [ ] CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
  • [ ] A docker base image is modified?
    • [ ] the relevant build-XXX-image label is present
    • [ ] To R&P team: locally build and push the image to hub.docker.com
  • [ ] A scenario is added (or removed)?
    • [ ] Get a review from R&P team
    • [ ] Once merged, add (or remove) it in system-test-dasboard nightly

cbeauchesne avatar Feb 20 '24 11:02 cbeauchesne

currently failing with

2024/02/20 11:21:42 [emerg] 8#8: dlopen() "/etc/nginx/modules/ngx_http_opentracing_module.so" failed (/lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.38' not found (required by /etc/nginx/modules/ngx_http_opentracing_module.so)) in /etc/nginx/nginx.conf:6
nginx: [emerg] dlopen() "/etc/nginx/modules/ngx_http_opentracing_module.so" failed (/lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.38' not found (required by /etc/nginx/modules/ngx_http_opentracing_module.so)) in /etc/nginx/nginx.conf:6

cbeauchesne avatar Feb 20 '24 11:02 cbeauchesne

Stolen from https://github.com/DataDog/system-tests/pull/2164

miry avatar Feb 20 '24 11:02 miry

issue addressed in another (which one?) PR

cbeauchesne avatar Jun 06 '24 08:06 cbeauchesne