system-tests
system-tests copied to clipboard
remove python sampling tag test skips
Description
This pull request removes the skips for Python and Python HTTP from most of the tests in tests/parametric/test_sampling_span_tags.py
. It also adjusts an expectation that had been erroneously committed related to the precedence order of sampling rules and rate limits.
I've run this locally against https://github.com/DataDog/dd-trace-py/pull/6693 and seen that the tests pass.
Motivation
https://github.com/DataDog/dd-trace-py/pull/6693 aligns the Python tracer's behavior with most of the assertions in this file. Since this change ~~is~~ will be in the latest release, we can keep this system-tests suite passing without needing to skip most tests for Python.
Workflow
- ⚠️⚠️ Create your PR as draft
- Follow the style guidelines of this project (See how to easily lint the code)
- Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
- Mark it as ready for review
Once your PR is reviewed, you can merge it! :heart:
Reviewer checklist
- [ ] Check what scenarios are modified. If needed, add the relevant label (
run-parametric-scenario
,run-profiling-scenario
...). If this PR modifies any system-tests internal, then add therun-all-scenarios
label (more info). - [ ] CI is green
- [ ] If not, failing jobs are not related to this change (and you are 100% sure about this statement)
- [ ] if any of
build-some-image
label is present- is the image labl have been updated ?
- just before merging, locally build and push the image to hub.docker.com
- [ ] if a scenario is added (or removed), add (or remove) it in system-test-dasboard nightly