integrations-core icon indicating copy to clipboard operation
integrations-core copied to clipboard

[NDM] use base 64 oids for memory from mempool mib

Open jedupau opened this issue 2 months ago • 2 comments

What does this PR do?

Related to this thread We use a base32 oid for memory which overflows for some devices

Motivation

Review checklist (to be filled by reviewers)

  • [ ] Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • [ ] Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • [ ] If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

jedupau avatar Oct 29 '25 14:10 jedupau

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 88.99%. Comparing base (d605a5b) to head (f0b0b8d). :warning: Report is 15 commits behind head on master.

Additional details and impacted files
:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Oct 29 '25 14:10 codecov[bot]

⚠️ Tests

⚠️ Warnings

🧪 1 Test failed

test_cisco_nexus from test_profiles.py (Datadog)
Needed at least 1 candidates for 'snmp.memory.free', got 0
Expected:
        MetricStub(name='snmp.memory.free', type=0, value=None, tags=['device_hostname:Nexus-eu1.companyname.managed', 'device_vendor:cisco', 'mem:1', 'snmp_device:localhost', 'snmp_host:Nexus-eu1.companyname.managed', 'snmp_profile:cisco-nexus'], hostname=None, device=None, flush_first_value=None)
Difference to closest:
        Expected name: snmp.memory.free
        Found snmp.cpmCPUMemoryFree
        Expected tag mem:1
        Found mem:None
        Expected tag cpu:None
        Found cpu:3173
...

ℹ️ Info

❄️ No new flaky tests detected

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: f0b0b8d | Docs | Datadog PR Page | Was this helpful? Give us feedback!

datadog-official[bot] avatar Oct 29 '25 14:10 datadog-official[bot]