integrations-core icon indicating copy to clipboard operation
integrations-core copied to clipboard

[AI-5800] Add quality gate to block PRs when size increase exceeds 1%

Open lucia-sb opened this issue 3 months ago • 8 comments

What does this PR do?

Implements size quality gates in the repository. Only integrations and dependencies that are packaged with the Agent are considered for size changes. For now, the threshold is set to 1%, meaning that if a pull request introduces a size increase greater than this threshold, the PR will be blocked.

Motivation

The Datadog Agent has strict size constraints. This gate will help maintain strict size control and prevent unintentional growth over time.

Review checklist (to be filled by reviewers)

  • [ ] Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • [ ] Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • [ ] If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

lucia-sb avatar Oct 06 '25 12:10 lucia-sb

⚠️ The qa/skip-qa label has been added with shippable changes

The following files, which will be shipped with the agent, were modified in this PR and the qa/skip-qa label has been added.

You can ignore this if you are sure the changes in this PR do not require QA. Otherwise, consider removing the label.

List of modified files that will be shipped with the agent
krakend/datadog_checks/test.txt

github-actions[bot] avatar Oct 06 '25 13:10 github-actions[bot]

Codecov Report

:x: Patch coverage is 67.62342% with 282 lines in your changes missing coverage. Please review. :white_check_mark: Project coverage is 91.02%. Comparing base (fba9966) to head (f07e747). :warning: Report is 65 commits behind head on master.

Additional details and impacted files
:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Oct 06 '25 14:10 codecov[bot]

⚠️ The qa/skip-qa label has been added with shippable changes

The following files, which will be shipped with the agent, were modified in this PR and the qa/skip-qa label has been added.

You can ignore this if you are sure the changes in this PR do not require QA. Otherwise, consider removing the label.

List of modified files that will be shipped with the agent
delinea_secret_server/datadog_checks/size.txt

github-actions[bot] avatar Oct 06 '25 15:10 github-actions[bot]

⚠️ Major version bump The changelog type changed or removed was used in this Pull Request, so the next release will bump major version. Please make sure this is a breaking change, or use the fixed or added type instead.

github-actions[bot] avatar Oct 07 '25 10:10 github-actions[bot]

✅ Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: f07e747 | Docs | Datadog PR Page | Was this helpful? Give us feedback!

Example of when quality gates don't pass: Screenshot 2025-10-28 at 12 25 10

lucia-sb avatar Oct 28 '25 11:10 lucia-sb

@codex review

lucia-sb avatar Oct 28 '25 16:10 lucia-sb

✅ Size Quality Gates Passed

These Quality Gates apply only to dependencies and integrations packaged with the Datadog Agent.

Threshold: 1.0% per platform and Python version
Compared to commit: c2b963f

Compressed Size Changes ✅

No size differences were found

Uncompressed Size Changes ✅

No size differences were found


📋 View detailed breakdown in GitHub Step Summary

github-actions[bot] avatar Nov 10 '25 19:11 github-actions[bot]