integrations-core icon indicating copy to clipboard operation
integrations-core copied to clipboard

DDSaaS: Mailchimp: Crawler integration without Assets

Open akaila-crest opened this issue 1 year ago • 4 comments

What does this PR do?

PR includes skeleton of Mailchimp integration without any assets like dashboards, image, README content, etc.

Motivation

This is beta release of crawler integration and is intended for internal testing before going live. As per @nathanmadams's suggestion, we are planning to raise separate PR with assets and all necessary information later.

Additional Notes

Only crawler-based integration related changes are included in this PR.

Review checklist (to be filled by reviewers)

  • [ ] Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • [ ] Changelog entries must be created for modifications to shipped code
  • [ ] Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • [ ] If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

akaila-crest avatar Aug 08 '24 13:08 akaila-crest

This PR should have been merged first before the CREATION of #18282 as you noted in the title:

As per @nathanmadams's suggestion, we are planning to raise separate PR with assets and all necessary information later.

But still produced both PRs. Please don't make the asset PR until the non-asset PR is merged

Wyrine avatar Aug 15 '24 19:08 Wyrine

This PR should have been merged first before the CREATION of #18282 as you noted in the title:

As per @nathanmadams's suggestion, we are planning to raise separate PR with assets and all necessary information later.

But still produced both PRs. Please don't make the asset PR until the non-asset PR is merged

Hi @Wyrine We have been following this approach since our first integration to have all PRs raised together if ready. For sure, the asset PR is only merged later then this. But this is our current and discussed approach since long and a LABEL assets no deploy is added to the assets PR until this no assets PR is merged. We don't have access to add or updating the labels but datadog team does the same. Happy to add a no deploy label if access is provided to us. Let us know if there are any concerns.

bhargavnariyanicrest avatar Aug 16 '24 05:08 bhargavnariyanicrest

This PR should have been merged first before the CREATION of #18282 as you noted in the title:

As per @nathanmadams's suggestion, we are planning to raise separate PR with assets and all necessary information later.

But still produced both PRs. Please don't make the asset PR until the non-asset PR is merged

Hi @Wyrine We have been following this approach since our first integration to have all PRs raised together if ready. For sure, the asset PR is only merged later then this. But this is our current and discussed approach since long and a LABEL assets no deploy is added to the assets PR until this no assets PR is merged. We don't have access to add or updating the labels but datadog team does the same. Happy to add a no deploy label if access is provided to us. Let us know if there are any concerns.

-- Also adding to context from past, Nathan suggested to raise this no asset PR to ensure Crawler team can deploy the code faster after the review for testing and other purposes, raising the asset PR on time is equally important to ensure we get the reviews going and changes done from other teams like log team, docs team etc without they too being blocked by crawler team for the reviews to complete.

bhargavnariyanicrest avatar Aug 16 '24 08:08 bhargavnariyanicrest

Hi @Wyrine We have been following this approach since our first integration to have all PRs raised together if ready. For sure, the asset PR is only merged later then this. But this is our current and discussed approach since long and a LABEL assets no deploy is added to the assets PR until this no assets PR is merged. We don't have access to add or updating the labels but datadog team does the same. Happy to add a no deploy label if access is provided to us. Let us know if there are any concerns.

-- Also adding to context from past, Nathan suggested to raise this no asset PR to ensure Crawler team can deploy the code faster after the review for testing and other purposes, raising the asset PR on time is equally important to ensure we get the reviews going and changes done from other teams like log team, docs team etc without they too being blocked by crawler team for the reviews to complete.

I believe this is resolved now given our slack discussion that Without Assets PR is to be merged before creation of the Assets PR moving forward.

Wyrine avatar Aug 16 '24 18:08 Wyrine