integrations-core icon indicating copy to clipboard operation
integrations-core copied to clipboard

[SIEMINT-88] DDS: Palo Alto Cortex XDR: Crawler Integration v1.0.0

Open surabhipatel-crest opened this issue 1 year ago • 7 comments

What does this PR do?

This is a initial release PR of Palo Alto Cortex XDR integration including all the required assets.

Additional Notes

  • Crawler code for this integration has been committed in its respective repo
  • Pipeline and Facet group created for this integration are available in our sandbox and would be shared separately with the required teams.
  • Samples for the pipeline review would also be shared separately with the required teams.
  • OOTB detection rules JSON would be shared separately with the required teams as a part of separate repository.
  • Since during the standard attribute remapping we are not preserving the source attributes as per suggested best practices, it would result in filters using these standard attributes populating the values of other integrations as well as per current Datadog behaviour

Review checklist (to be filled by reviewers)

  • [ ] Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • [ ] Changelog entries must be created for modifications to shipped code
  • [ ] Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • [ ] If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

surabhipatel-crest avatar Jul 22 '24 05:07 surabhipatel-crest

Created DOCS-8519 for editorial review.

maycmlee avatar Jul 23 '24 19:07 maycmlee

@surabhipatel-crest please rebase this PR to resolve the conflicts

nathanmadams avatar Jul 26 '24 20:07 nathanmadams

@surabhipatel-crest please rebase and fix conflicts

Wyrine avatar Jul 30 '24 19:07 Wyrine

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 85.56%. Comparing base (de756fe) to head (3032b78).

Additional details and impacted files
Flag Coverage Δ
activemq ?
cassandra ?
hive ?
hivemq ?
ignite ?
jboss_wildfly ?
kafka ?
kyverno 82.27% <ø> (ø)
solr ?

Flags with carried forward coverage won't be shown. Click here to find out more.

codecov[bot] avatar Aug 05 '24 09:08 codecov[bot]

@surabhipatel-crest please rebase and fix conflicts

We have re-base the branch and resolved all the merge conflicts. We think due to rebase some un-necessary tags/labels are applied. Please remove it as we do not have access to add/remove tags on PR.

ravindrasojitra-crest avatar Aug 05 '24 11:08 ravindrasojitra-crest

@surabhipatel-crest please rebase and fix conflicts

We have re-base the branch and resolved all the merge conflicts. We think due to rebase some un-necessary tags/labels are applied. Please remove it as we do not have access to add/remove tags on PR.

@ravindrasojitra-crest please don't do this in the future. Only merge master branch in, no rebasing.

iliakur avatar Aug 05 '24 11:08 iliakur

@surabhipatel-crest please rebase and fix conflicts

We have re-base the branch and resolved all the merge conflicts. We think due to rebase some un-necessary tags/labels are applied. Please remove it as we do not have access to add/remove tags on PR.

@ravindrasojitra-crest please don't do this in the future. Only merge master branch in, no rebasing.

Sure, in future we will only merge master branch in. Thank you..!!

ravindrasojitra-crest avatar Aug 05 '24 11:08 ravindrasojitra-crest