integrations-core icon indicating copy to clipboard operation
integrations-core copied to clipboard

[SIEMINT-76] [Release] [DDS] PingOne: Crawler Integration v1.0.0

Open savandalasaniya-crest opened this issue 1 year ago • 10 comments

What does this PR do?

This is a initial release PR of PingOne integration including all the required assets.

Additional Notes

  • Crawler code for this integration has been committed in its respective repo
  • Pipeline and Facet group created for this integration are available in our sandbox and would be shared separately with the required teams.
  • Samples for the pipeline review would also be shared separately with the required teams.
  • OOTB detection rules JSON would be shared separately with the required teams as a part of separate repository ..
  • Since during the standard attribute remapping we are not preserving the source attributes as per suggested best practices, it would result in filters using these standard attributes populating the values of other integrations as well as per current Datadog behavior

Review checklist (to be filled by reviewers)

  • [ ] Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • [ ] Changelog entries must be created for modifications to shipped code
  • [ ] Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • [ ] If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

savandalasaniya-crest avatar Jun 27 '24 14:06 savandalasaniya-crest

Setting the assets/no-deploy flag on this until https://github.com/DataDog/integrations-core/pull/17870 merges

nathanmadams avatar Jun 28 '24 18:06 nathanmadams

Thanks, created DOCS-8353 to review

buraizu avatar Jun 28 '24 19:06 buraizu

Thanks for making the changes to the message remapper, everything looks good for the logs integration pipeline. Will approve after I can test in staging once this comment from @nathanmadams is resolved and the other PR is merged

vishalshah-dd avatar Jul 02 '24 13:07 vishalshah-dd

The other PR just merged so I think you'll need to rebase this one. Once you do, feel free to remove the assets/no-deploy label so it can be reviewed.

nathanmadams avatar Jul 02 '24 16:07 nathanmadams

@nathanmadams I have rebase the branch. But don't have permission to remove label: assets/no-deploy. Can you please update this?

akanshi-crest avatar Jul 03 '24 14:07 akanshi-crest

@nathanmadams I have rebase the branch. But don't have permission to remove label: assets/no-deploy. Can you please update this?

Just took care of it, I'll get this in staging and will approve after I can test it out

vishalshah-dd avatar Jul 03 '24 14:07 vishalshah-dd

Just merged master to see if the validations would re-run successfully.

mgarabed avatar Jul 17 '24 14:07 mgarabed

Does this PR look good to merge?

bhargavnariyanicrest avatar Jul 23 '24 06:07 bhargavnariyanicrest

thank you!

@Wyrine Are we good to merge this PR after this change?

akanshi-crest avatar Jul 24 '24 15:07 akanshi-crest

Are we good to merge this PR after this change?

Yes, good to merge!

Wyrine avatar Jul 24 '24 15:07 Wyrine