Send out container uptime metrics for ECS Fargate
What does this PR do?
Introduce container uptime metrics for ECS Fargate tasks.
Motivation
We run batch jobs on ECS Fargate and wanted to have metrics (in order to be alerted, but also compare performance, etc.) on how long they take to run.
Additional Notes
This has been tested and appears to work on our installation.
Review checklist (to be filled by reviewers)
- [ ] Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
- [ ] Changelog entries must be created for modifications to shipped code
- [ ] Add the
qa/skip-qalabel if the PR doesn't need to be tested during QA. - [ ] If you need to backport this PR to another branch, you can add the
backport/<branch-name>label to the PR and it will automatically open a backport PR once this one is merged
Codecov Report
Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.
Project coverage is 88.02%. Comparing base (
13b7646) to head (f7fb650). Report is 1429 commits behind head on master.
Additional details and impacted files
| Flag | Coverage Δ | |
|---|---|---|
| activemq | ? |
|
| cassandra | ? |
|
| ecs_fargate | ∅ <75.00%> (∅) |
|
| hive | ? |
|
| hivemq | ? |
|
| hudi | ? |
|
| ignite | ? |
|
| jboss_wildfly | ? |
|
| kafka | ? |
|
| presto | ? |
|
| solr | ? |
Flags with carried forward coverage won't be shown. Click here to find out more.
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
- :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
Ah, this appears to fail on Python 2. I'll look into the alternatives for the timezone library.
I see we have some utilities in the code for dealing with time (added in/around #6692), will migrate to using these, they seem Python-version-tolerant.
Yay, it sounds like that did it. This should be ready to review.
This value should already exist in the generic container check through container.uptime metric, it's available on Fargate as well. Are you aware of this metric, and if yes, if there any issue using it?
Closing in light of the previous comments. Please re-open if needed.