integrations-core icon indicating copy to clipboard operation
integrations-core copied to clipboard
verified publisher icon DataDog

fix: Confluent Platform Intergration - Correct Mbean regex stream thread metric

Open tlsdnwn55 opened this issue 1 year ago • 5 comments

What does this PR do?

Fixed the JMX Mbean regex to collect stream thread metrics of ksqldb in Confluent Platform. And added the blocked-time-ns-total metric. (described in confluent docs as being very useful for debugging Kafka Streams application performance)

Motivation

I am maintaining a confluent platform, and while configuring the ksqldb dashboard, I discovered that stream thread metrics were not collected.

Additional Notes

Review checklist (to be filled by reviewers)

  • [ ] Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • [ ] Changelog entries must be created for modifications to shipped code
  • [ ] Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • [ ] If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

tlsdnwn55 avatar May 01 '24 00:05 tlsdnwn55

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 88.83%. Comparing base (2a6ec26) to head (4bc637c). Report is 113 commits behind head on master.

Additional details and impacted files
Flag Coverage Δ
confluent_platform 81.96% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

codecov[bot] avatar May 01 '24 00:05 codecov[bot]

Test Results

8 files  8 suites   53s :stopwatch: 1 tests 1 :white_check_mark: 0 :zzz: 0 :x: 8 runs  4 :white_check_mark: 4 :zzz: 0 :x:

Results for commit d07f2869.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar May 01 '24 00:05 github-actions[bot]

@jhgilbert thank you for your approve.

tlsdnwn55 avatar May 02 '24 01:05 tlsdnwn55

@jhgilbert how may i merge this pr?

tlsdnwn55 avatar May 08 '24 12:05 tlsdnwn55

@steveny91 Could you please confirm?

tlsdnwn55 avatar May 13 '24 03:05 tlsdnwn55

Looks good on my end. Thanks for the contribution. I'll get this merged in next week so that it can be released with the next agent (7.55).

One last nit is to rename the changelog enty file from .fixed to .added. But I can take care of that as well next week. Thanks again!

steveny91 avatar May 23 '24 17:05 steveny91

@steveny91 thank you! renamed the changelog to be more appropriate as suggested. Thank you again for accepting my PR.

tlsdnwn55 avatar May 24 '24 11:05 tlsdnwn55

@tlsdnwn55 no problem! Thanks for the contribution! I'll merge this in this week.

steveny91 avatar May 28 '24 14:05 steveny91