integrations-core icon indicating copy to clipboard operation
integrations-core copied to clipboard

[DBMON-3520] - add pg_stat_io metrics to postgres integration

Open eric-weaver opened this issue 1 year ago • 3 comments

What does this PR do?

Adds the following pg_stat_io metrics to the postgres integration. These will only be available un postgres 16+. For now we'll want to only expose these for DBM users.

  • postgresql.io.evictions
  • postgresql.io.extends
  • postgresql.io.extend_time
  • postgresql.io.fsyncs
  • postgresql.io.fsync_time
  • postgresql.io.hits
  • postgresql.io.reads
  • postgresql.io.read_time
  • postgresql.io.writes
  • postgresql.io.write_time

Each of these metrics will include the following tags: backend_type, context, object.

Motivation

IO stat metrics were a big blindspot in older postgres versions. Exposing these will allow users to have better visibility into where IO time is being spent.

Additional Notes

This is my first contribution to integrations-core / postgres integration so any comments on direction of these changes is appreciated!

Review checklist (to be filled by reviewers)

  • [ ] Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • [ ] Changelog entries must be created for modifications to shipped code
  • [ ] Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • [ ] If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

eric-weaver avatar Apr 19 '24 19:04 eric-weaver

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

github-actions[bot] avatar Apr 19 '24 19:04 github-actions[bot]

Test Results

   16 files     16 suites   21m 40s :stopwatch:   288 tests   286 :white_check_mark:   2 :zzz: 0 :x: 2 312 runs  2 183 :white_check_mark: 129 :zzz: 0 :x:

Results for commit a2fe5ff6.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar Apr 19 '24 19:04 github-actions[bot]

Codecov Report

Attention: Patch coverage is 91.30435% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 85.16%. Comparing base (2a6ec26) to head (b5ce4d1). Report is 38 commits behind head on master.

:exclamation: Current head b5ce4d1 differs from pull request most recent head a2fe5ff. Consider uploading reports for the commit a2fe5ff to get more accurate results

Additional details and impacted files
Flag Coverage Δ
active_directory ?
activemq_xml ?
aerospike ?
amazon_msk ?
ambari ?
arangodb ?
avi_vantage ?
azure_iot_edge ?
cisco_aci ?
citrix_hypervisor ?
cloudera ?
couchbase ?
crio ?
datadog_checks_downloader ?
datadog_cluster_agent ?
dcgm ?
ddev ?
dns_check ?
dotnetclr ?
druid ?
ecs_fargate ?
elastic ?
external_dns ?
gearmand ?
glusterfs ?
gunicorn ?
haproxy ?
harbor ?
http_check ?
ibm_db2 ?
ibm_was ?
iis ?
karpenter ?
kube_apiserver_metrics ?
kube_controller_manager ?
kube_dns ?
kube_metrics_server ?
kube_proxy ?
kube_scheduler ?
kubernetes_state ?
kyototycoon ?
linux_proc_extras ?
mapr ?
marathon ?
marklogic ?
mcache ?
mesos_slave ?
nagios ?
network ?
nfsstat ?
nginx ?
nginx_ingress_controller ?
nvidia_triton ?
openmetrics ?
oracle ?
pdh_check ?
pgbouncer ?
php_fpm ?
postfix ?
postgres 92.79% <91.30%> (-0.01%) :arrow_down:
process ?
prometheus ?
rabbitmq ?
ray ?
redisdb ?
riakcs ?
scylla ?
silk ?
snmp ?
snowflake ?
sonarqube ?
spark ?
ssh_check ?
statsd ?
strimzi ?
system_core ?
system_swap ?
tcp_check ?
teamcity ?
temporal ?
twemproxy ?
twistlock ?
varnish ?
vault ?
vertica ?
voltdb ?
vsphere ?
weaviate ?
win32_event_log ?
zk ?

Flags with carried forward coverage won't be shown. Click here to find out more.

codecov[bot] avatar Apr 22 '24 19:04 codecov[bot]