integrations-core
integrations-core copied to clipboard
DataDog
Hazelcast integration - Add queues, topics and reltopics and name tag.
What does this PR do?
- Add metrics for queues, topics and reltopics.
- Add the name tag so that we can see more detailed metrics.
Motivation
The Hazelcast integration is not showing important details such as the map name that's being monitored. It would be great to include that, as well as include metrics for other things such as queues and topics so that we can get finer grained visibility to the maps, queues and topics that we are most interested in as a Datadog customer using Hazelcast.
Additional Notes
This is my first PR to DD, sorry if I did not follow guidelines.
Review checklist (to be filled by reviewers)
- [x ] Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
- [ x] Changelog entries must be created for modifications to shipped code
- [ x] Add the
qa/skip-qalabel if the PR doesn't need to be tested during QA. - [ x] If you need to backport this PR to another branch, you can add the
backport/<branch-name>label to the PR and it will automatically open a backport PR once this one is merged
Test Results
2 files 2 suites 43s :stopwatch: 2 tests 1 :white_check_mark: 0 :zzz: 1 :x: 3 runs 1 :white_check_mark: 1 :zzz: 1 :x:
For more details on these failures, see this check.
Results for commit d2002e1b.
:recycle: This comment has been updated with latest results.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
The changelog type changed or removed was used in this Pull Request, so the next release will bump major version. Please make sure this is a breaking change, or use the fixed or added type instead.
The changelog type changed or removed was used in this Pull Request, so the next release will bump major version. Please make sure this is a breaking change, or use the fixed or added type instead.
The changelog type changed or removed was used in this Pull Request, so the next release will bump major version. Please make sure this is a breaking change, or use the fixed or added type instead.
The changelog type changed or removed was used in this Pull Request, so the next release will bump major version. Please make sure this is a breaking change, or use the fixed or added type instead.
The changelog type changed or removed was used in this Pull Request, so the next release will bump major version. Please make sure this is a breaking change, or use the fixed or added type instead.
The changelog type changed or removed was used in this Pull Request, so the next release will bump major version. Please make sure this is a breaking change, or use the fixed or added type instead.
The changelog type changed or removed was used in this Pull Request, so the next release will bump major version. Please make sure this is a breaking change, or use the fixed or added type instead.
The changelog type changed or removed was used in this Pull Request, so the next release will bump major version. Please make sure this is a breaking change, or use the fixed or added type instead.
The changelog type changed or removed was used in this Pull Request, so the next release will bump major version. Please make sure this is a breaking change, or use the fixed or added type instead.
The changelog type changed or removed was used in this Pull Request, so the next release will bump major version. Please make sure this is a breaking change, or use the fixed or added type instead.
The changelog type changed or removed was used in this Pull Request, so the next release will bump major version. Please make sure this is a breaking change, or use the fixed or added type instead.
The changelog type changed or removed was used in this Pull Request, so the next release will bump major version. Please make sure this is a breaking change, or use the fixed or added type instead.
There appeared to be some confusion in the past (myself included) on the hazelcast mc health checks - this reports the status of hazelcast's management center, not the status of the cluster managed by management center, since there are multiple clusters which can be managed by mancenter, this makes sense in a way.
Therefore, the status of frozen, no migration, etc aren't ever going to show for this check.
This check simply checks mancenter's heath probe endpoint to confirm if it is up / working. I don't think mancenter is opensource, so I can't see the possible statuses here, but I suspect this is hardcoded and just used for readiness / liveness probes.
I was able to dig up the old docs - the cluster state got conflated - https://docs.hazelcast.org/docs/management-center/latest/manual/html/index.html#cluster-state however if you read this section https://web.archive.org/web/20200511115951/https://docs.hazelcast.org/docs/management-center/latest/manual/html/index.html#enabling-health-check-endpoint it's clear this is just and endpoint for health checks.
The changelog type changed or removed was used in this Pull Request, so the next release will bump major version. Please make sure this is a breaking change, or use the fixed or added type instead.
The changelog type changed or removed was used in this Pull Request, so the next release will bump major version. Please make sure this is a breaking change, or use the fixed or added type instead.
The changelog type changed or removed was used in this Pull Request, so the next release will bump major version. Please make sure this is a breaking change, or use the fixed or added type instead.
Codecov Report
Attention: Patch coverage is 95.45455% with 1 line in your changes missing coverage. Please review.
Project coverage is 89.23%. Comparing base (
ba6e607) to head (bd42137). Report is 202 commits behind head on master.
Additional details and impacted files
| Flag | Coverage Δ | |
|---|---|---|
| activemq | ? |
|
| cassandra | ? |
|
| hazelcast | 92.30% <95.45%> (-0.09%) |
:arrow_down: |
| hive | ? |
|
| hivemq | ? |
|
| hudi | ? |
|
| ignite | ? |
|
| jboss_wildfly | ? |
|
| kafka | ? |
|
| presto | ? |
|
| solr | ? |
Flags with carried forward coverage won't be shown. Click here to find out more.
![codecov[bot] avatar](https://avatars.githubusercontent.com/in/254?v=4 "Published by a pub.dev verified publisher"){kind=small}
The changelog type changed or removed was used in this Pull Request, so the next release will bump major version. Please make sure this is a breaking change, or use the fixed or added type instead.
The changelog type changed or removed was used in this Pull Request, so the next release will bump major version. Please make sure this is a breaking change, or use the fixed or added type instead.
The changelog type changed or removed was used in this Pull Request, so the next release will bump major version. Please make sure this is a breaking change, or use the fixed or added type instead.
The changelog type changed or removed was used in this Pull Request, so the next release will bump major version. Please make sure this is a breaking change, or use the fixed or added type instead.
The changelog type changed or removed was used in this Pull Request, so the next release will bump major version. Please make sure this is a breaking change, or use the fixed or added type instead.
The changelog type changed or removed was used in this Pull Request, so the next release will bump major version. Please make sure this is a breaking change, or use the fixed or added type instead.
The changelog type changed or removed was used in this Pull Request, so the next release will bump major version. Please make sure this is a breaking change, or use the fixed or added type instead.
Hi @buraizu! I was able to work on this with Brett and got CI to pass. Could you take another look at this PR for me or let me know how to get the review process restarted?
The changelog type changed or removed was used in this Pull Request, so the next release will bump major version. Please make sure this is a breaking change, or use the fixed or added type instead.