integrations-core icon indicating copy to clipboard operation
integrations-core copied to clipboard

Added checkpoint quantum firewall integration

Open tirthrajchaudhari-crest opened this issue 1 year ago • 7 comments

What does this PR do?

PR for a new integration Checkpoint Quantum Firewall 1.0.0

Other Notes:

-- Pipeline and Facet group created for this integration are available in our sandbox and would be shared separately with the required teams. -- Samples for the pipeline review would also be shared separately with the required teams. -- OOTB detection rules JSON would be shared separately with the required teams. -- Since during the standard attribute remapping we are not preserving the source attributes as per suggested best practices, it would result in filters using these standard attributes populating the values of other integrations as well as per current datadog behaviour.

Review checklist (to be filled by reviewers)

  • [ ] Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • [ ] Changelog entries must be created for modifications to shipped code
  • [ ] Add the qa/skip-qa label if the PR doesn't need to be tested during QA.

tirthrajchaudhari-crest avatar Jan 03 '24 13:01 tirthrajchaudhari-crest

👋 Could you have a look at this comment? I think you have the same issue

FlorentClarret avatar Jan 03 '24 15:01 FlorentClarret

👋 Could you have a look at this comment? I think you have the same issue

Sure will do.

bhargavnariyanicrest avatar Jan 03 '24 16:01 bhargavnariyanicrest

@alai97 Commited the review comment changes, can you please re review?

bhargavnariyanicrest avatar Jan 10 '24 10:01 bhargavnariyanicrest

@ DD PMs: I re-synced the tile and assets to staging

FlorentClarret avatar Jan 19 '24 11:01 FlorentClarret

Hello @mohittilala-crest @tirthrajchaudhari-crest 👋 FYI I'm going to push a commit to this PR to fix something with the changelogs. I don't want to bother you with this, this is more an internal change we are doing.

We are going to update the template used by the ddev create command very soon so you won't have to worry about it in the future.

FlorentClarret avatar Jan 19 '24 14:01 FlorentClarret

LGTM once the validation will be green

FlorentClarret avatar Feb 02 '24 09:02 FlorentClarret

LGTM, just waiting for the other teams to approve and we'll merge 🙂

FlorentClarret avatar Mar 19 '24 09:03 FlorentClarret

I've left a few nit comments but I will be testing the integration in staging tomorrow

txominpelu avatar Mar 20 '24 16:03 txominpelu

@FlorentClarret why was the version updated to 0.0.1 here?

Thanks gor clarification

bhargavnariyanicrest avatar Mar 21 '24 12:03 bhargavnariyanicrest

It looks good from the logs side based on staging tests.

Screenshot 2024-03-21 at 14 06 30

txominpelu avatar Mar 21 '24 13:03 txominpelu

@jnhunsberger @alai97 is it good to be merged on your side ? Can you approve if it looks good for you ? I will merge it when that's the case.

txominpelu avatar Mar 21 '24 13:03 txominpelu

The changelog type changed was used in this Pull Request, so the next release will bump major version. Please make sure this is a breaking change, or use the fixed or added type instead.

github-actions[bot] avatar Mar 28 '24 10:03 github-actions[bot]

The backport to 7.53.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-7.53.x 7.53.x
# Navigate to the new working tree
cd .worktrees/backport-7.53.x
# Create a new branch
git switch --create backport-16522-to-7.53.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 f9b17b5f06723b3f212562cc1ed996aa5f267344
# Push it to GitHub
git push --set-upstream origin backport-16522-to-7.53.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-7.53.x

Then, create a pull request where the base branch is 7.53.x and the compare/head branch is backport-16522-to-7.53.x.

The changelog type changed was used in this Pull Request, so the next release will bump major version. Please make sure this is a breaking change, or use the fixed or added type instead.

github-actions[bot] avatar Mar 28 '24 10:03 github-actions[bot]

The backport to 7.53.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-7.53.x 7.53.x
# Navigate to the new working tree
cd .worktrees/backport-7.53.x
# Create a new branch
git switch --create backport-16522-to-7.53.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 f9b17b5f06723b3f212562cc1ed996aa5f267344
# Push it to GitHub
git push --set-upstream origin backport-16522-to-7.53.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-7.53.x

Then, create a pull request where the base branch is 7.53.x and the compare/head branch is backport-16522-to-7.53.x.