integrations-core icon indicating copy to clipboard operation
integrations-core copied to clipboard

[ClickHouse] Add async insert related metrics

Open chhetripradeep opened this issue 2 years ago • 2 comments

What does this PR do?

This PR adds two metrics related to async inserts

Motivation

Async insert is becoming the default way of inserting data in ClickHouse and ClickHouse Users are using it for its ease and performance over normal insert.

Additional Notes

Including just two metrics which are the most useful :) Keeping the same nomenclature for metrics as used for normal inserts.

Review checklist (to be filled by reviewers)

  • [ ] Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • [ ] Changelog entries must be created for modifications to shipped code
  • [ ] Add the qa/skip-qa label if the PR doesn't need to be tested during QA.

chhetripradeep avatar Dec 11 '23 16:12 chhetripradeep

Test Results

 4 files   4 suites   3m 56s :stopwatch: 14 tests  8 :white_check_mark:  3 :zzz: 0 :x: 3 :fire: 56 runs  41 :white_check_mark: 12 :zzz: 0 :x: 3 :fire:

For more details on these errors, see this check.

Results for commit b82163b0.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar Dec 11 '23 16:12 github-actions[bot]

Hi Team, Looking at the test failure, I found that the newly added metrics only get populated when we do an async insert into clickhouse since async_insert is not enabled by default: INSERT INTO <table> .... SETTINGS async_insert = 1 Can you give me pointer how can i set clickhouse configuration async_insert = 1 for clickhouse containers started via tests

chhetripradeep avatar Dec 12 '23 01:12 chhetripradeep

We included these changes in https://github.com/DataDog/integrations-core/pull/17218.

Thanks for the PR!

FlorentClarret avatar Apr 02 '24 08:04 FlorentClarret