integrations-core icon indicating copy to clipboard operation
integrations-core copied to clipboard

Fix profile mapping for _cisco-catalyst.yaml

Open AlexandreYang opened this issue 2 years ago • 4 comments

What does this PR do?

Fix profile mapping for _cisco-catalyst.yaml

Motivation

Additional Notes

Review checklist (to be filled by reviewers)

  • [ ] Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • [ ] Changelog entries must be created for modifications to shipped code
  • [ ] Add the qa/skip-qa label if the PR doesn't need to be tested during QA.

AlexandreYang avatar Sep 08 '23 15:09 AlexandreYang

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (8274fa9) 86.32% compared to head (5d8801b) 86.24%. Report is 852 commits behind head on master.

Additional details and impacted files
Flag Coverage Δ
snmp 48.61% <ø> (+0.01%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

codecov[bot] avatar Sep 08 '23 15:09 codecov[bot]

Test Results

       5 files      5 suites   27m 15s :stopwatch:    399 tests 396 :heavy_check_mark:        1 :zzz: 2 :x: 1 637 runs  576 :heavy_check_mark: 1 059 :zzz: 2 :x:

For more details on these failures, see this check.

Results for commit 5d8801b9.

github-actions[bot] avatar Sep 08 '23 15:09 github-actions[bot]

Hey @AlexandreYang 👋 Should we try to include this PR in 7.51?

FlorentClarret avatar Jan 03 '24 08:01 FlorentClarret

@FlorentClarret 👋 The PR is not ready yet and I probably won't have time to look at them before freeze, so likely better to keep for future version.

AlexandreYang avatar Jan 03 '24 10:01 AlexandreYang