integrations-core icon indicating copy to clipboard operation
integrations-core copied to clipboard

Documentation for SQL Server configuration is confusing

Open williamscs opened this issue 2 years ago • 0 comments

Reading through the setup documentation here, it says that the "name" value should be configured.

https://docs.datadoghq.com/database_monitoring/setup_sql_server/azure/?tab=kubernetes#configure-with-kubernetes-service-annotations

image

However, the link provided is somewhat broken and instead of "name" there is "fully_qualified_domain_name" with a claim that there should be some sort of fallback if not provided.

https://github.com/DataDog/integrations-core/blob/master/sqlserver/assets/configuration/spec.yaml#L353-L383

image

When we attempted to rely on this documented fallback, it broke with the check saying "name" is not configured.

https://github.com/DataDog/integrations-core/blob/7a8c47352d54010993cf2b2544cc7ac8d4b9b07f/sqlserver/datadog_checks/sqlserver/sqlserver.py#L225

We're a little confused on what the appropriate configuration should be.

williamscs avatar Jul 21 '23 13:07 williamscs