integrations-core
integrations-core copied to clipboard
attempt to support clusterAllReplicas for clickhouse datadog agent
What does this PR do?
https://github.com/DataDog/integrations-core/issues/14199
Update clickhouse datadog agent client to have ability to specify a cluster name, and query system tables with clusterAllReplicas option.
Motivation
Datadog agent currently is not working with clickhouse clusters running across more than one node. This PR is an attempt to support monitoring multi-node clickhouse deployment by datadog agent.
Additional Notes
I am yet to build/test locally.
Review checklist (to be filled by reviewers)
- [ ] Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
- [ ] PR title must be written as a CHANGELOG entry (see why)
- [ ] Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
- [ ] PR must have
changelog/
andintegration/
labels attached - [ ] If the PR doesn't need to be tested during QA, please add a
qa/skip-qa
label.
You can build and test your changes using our CLI tool
ddev
. After installingddev
, you can spin up a test environment for clickhouse usingddev env start clickhouse <environment>
. To see the possibleddev
test environments we currently support, runddev env ls clickhouse
.
Hi there, I tried ddev, but got bash-3.2$ ddev env ls clickhouse No testable checks found for: clickhouse
instead.
How may I set up the test environment for ClickHouse first?
Test Results
14 tests 3 :heavy_check_mark: 35s :stopwatch: 1 suites 3 :zzz: 1 files 8 :x:
For more details on these failures, see this check.
Results for commit 682a59c0.
Hi there, I tried ddev, but got
bash-3.2$ ddev env ls clickhouse No testable checks found for: clickhouse
instead.
The most likely reason for that is that you didn't configure ddev
to point at your copy of the repo. You can run ddev config edit
to edit the config and make sure that it's pointing to the path where you cloned the integrations-core repo:
[repos]
core = "~/path/to/integrations-core"
Hey @sichenzhao, did you get to try my tip above? Let us know if there is anything we can do to help you towards getting this into shape.