integrations-core icon indicating copy to clipboard operation
integrations-core copied to clipboard

Update default configuration for collect_default_database to true

Open alexandre-normand opened this issue 1 year ago • 4 comments

What does this PR do?

This PR aims to address confusion that comes up related to missing data due to the default postgres database being ignored. This updates the default configuration to enable data collection on the default database.

Note that this is technically a breaking change because the collection behavior is going to change. We're going ahead with this change because it's going to be a better overall experience moving forward.

Motivation

Additional Notes

Review checklist (to be filled by reviewers)

  • [ ] Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • [ ] PR title must be written as a CHANGELOG entry (see why)
  • [ ] Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • [ ] PR must have changelog/ and integration/ labels attached

alexandre-normand avatar Sep 21 '22 23:09 alexandre-normand

Label changelog/Changed was added to this Pull Request, so the next release will bump major version. Please make sure this is a breaking change, or use the changelog/Fixed label.

github-actions[bot] avatar Sep 21 '22 23:09 github-actions[bot]

Label changelog/Changed was added to this Pull Request, so the next release will bump major version. Please make sure this is a breaking change, or use the changelog/Fixed label.

github-actions[bot] avatar Sep 21 '22 23:09 github-actions[bot]

Label changelog/Changed was added to this Pull Request, so the next release will bump major version. Please make sure this is a breaking change, or use the changelog/Fixed label.

github-actions[bot] avatar Sep 21 '22 23:09 github-actions[bot]

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

github-actions[bot] avatar Sep 21 '22 23:09 github-actions[bot]

Codecov Report

Merging #12999 (8ba5d45) into master (ed547c1) will increase coverage by 0.00%. The diff coverage is 100.00%.

Flag Coverage Δ
postgres 91.87% <100.00%> (+0.19%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

codecov[bot] avatar Sep 22 '22 22:09 codecov[bot]