integrations-core
integrations-core copied to clipboard
Honor ignore_databases in query metrics collection
What does this PR do?
This PR aims to address confusion that comes up related to inconsistent treatment the ignore_databases
configuration:
- Query samples/activity and core metrics honored the
ignore_databases
while query metrics collection ignored it.
Note that this is technically a breaking change because the collection behavior is going to change. We're going ahead with this change because it's going to be a better overall experience moving forward.
Motivation
Customer frustration around missing query plans / query activity because the main database used was postgres
and is ignored by default.
Additional Notes
Review checklist (to be filled by reviewers)
- [x] Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
- [ ] PR title must be written as a CHANGELOG entry (see why)
- [ ] Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
- [ ] PR must have
changelog/
andintegration/
labels attached
Label changelog/Changed
was added to this Pull Request, so the next release will bump major version. Please make sure this is a breaking change, or use the changelog/Fixed
label.
Label changelog/Changed
was added to this Pull Request, so the next release will bump major version. Please make sure this is a breaking change, or use the changelog/Fixed
label.
The validations
job has failed; please review the Files changed
tab for possible suggestions to resolve.
Label changelog/Changed
was added to this Pull Request, so the next release will bump major version. Please make sure this is a breaking change, or use the changelog/Fixed
label.
Codecov Report
Merging #12998 (0101e3e) into master (ed547c1) will increase coverage by
0.00%
. The diff coverage is100.00%
.
Flag | Coverage Δ | |
---|---|---|
postgres | 92.00% <100.00%> (+0.32%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.