integrations-core icon indicating copy to clipboard operation
integrations-core copied to clipboard

Fix missing latency metrics from other namespaces

Open ian28223 opened this issue 2 years ago • 1 comments

What does this PR do?

Fix missing latency metrics from other namespaces. This allows the check to continue processing next lines following an invalid line. Example, {foo}-pi-query: line is considered invalid (due to regex not matching) and prevents following lines with potentially valid metrics from being processed.

latencies: batch-index:msec,172.1,0.06,0.00,0.00,0.00,0.00,0.00,0.00,0.00,0.00,0.00,0.00,0.00,0.00,0.00,0.00,0.00,0.00
{foo}-read:msec,0.0,0.00,0.00,0.00,0.00,0.00,0.00,0.00,0.00,0.00,0.00,0.00,0.00,0.00,0.00,0.00,0.00,0.00
{foo}-write:msec,0.4,0.00,0.00,0.00,0.00,0.00,0.00,0.00,0.00,0.00,0.00,0.00,0.00,0.00,0.00,0.00,0.00,0.00
{foo}-udf:
{foo}-pi-query:
{foo}-si-query:
{bar}-read:msec,0.1,0.00,0.00,0.00,0.00,0.00,0.00,0.00,0.00,0.00,0.00,0.00,0.00,0.00,0.00,0.00,0.00,0.00
{bar}-write:msec,0.0,0.00,0.00,0.00,0.00,0.00,0.00,0.00,0.00,0.00,0.00,0.00,0.00,0.00,0.00,0.00,0.00,0.00
{bar}-udf:
{bar}-pi-query:
{bar}-si-query:

Motivation

AGENT-8634

Additional Notes

Review checklist (to be filled by reviewers)

  • [ ] Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • [ ] PR title must be written as a CHANGELOG entry (see why)
  • [ ] Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • [ ] PR must have changelog/ and integration/ labels attached

ian28223 avatar Sep 16 '22 04:09 ian28223

Codecov Report

Merging #12944 (026df0b) into master (08d2a4f) will increase coverage by 0.00%. The diff coverage is 100.00%.

Flag Coverage Δ
aerospike 87.17% <100.00%> (+1.01%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

codecov[bot] avatar Sep 16 '22 21:09 codecov[bot]