integrations-core
integrations-core copied to clipboard
DataDog
Support TeamCity metrics and service checks
What does this PR do?
Rewrites the TeamCity check to:
- Collect metrics from openmetrics and REST API endpoints
- Submit failed build events
- Submit build status and build problem service checks
- Collect multiple build configurations per instance
Motivation
Additional Notes
Review checklist (to be filled by reviewers)
- [ ] Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
- [ ] PR title must be written as a CHANGELOG entry (see why)
- [ ] Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
- [ ] PR must have
changelog/andintegration/labels attached
Codecov Report
Merging #12852 (92f521a) into master (a9d2378) will decrease coverage by
1.25%. The diff coverage is87.76%.
| Flag | Coverage Δ | |
|---|---|---|
| active_directory | ? |
|
| activemq_xml | ? |
|
| aerospike | ? |
|
| airflow | ? |
|
| amazon_msk | ? |
|
| ambari | ? |
|
| apache | ? |
|
| arangodb | ? |
|
| aspdotnet | ? |
|
| avi_vantage | ? |
|
| azure_iot_edge | ? |
|
| boundary | ? |
|
| btrfs | ? |
|
| cacti | ? |
|
| calico | ? |
|
| cassandra_nodetool | ? |
|
| ceph | ? |
|
| cert_manager | ? |
|
| cilium | ? |
|
| cisco_aci | ? |
|
| citrix_hypervisor | ? |
|
| clickhouse | ? |
|
| cloud_foundry_api | ? |
|
| cockroachdb | ? |
|
| consul | ? |
|
| coredns | ? |
|
| couch | ? |
|
| couchbase | ? |
|
| crio | ? |
|
| datadog_checks_base | ? |
|
| datadog_checks_dev | ? |
|
| datadog_checks_downloader | ? |
|
| datadog_cluster_agent | ? |
|
| ddev | ? |
|
| directory | ? |
|
| disk | ? |
|
| dns_check | ? |
|
| dotnetclr | ? |
|
| druid | ? |
|
| ecs_fargate | ? |
|
| eks_fargate | ? |
|
| elastic | ? |
|
| envoy | ? |
|
| etcd | ? |
|
| exchange_server | ? |
|
| external_dns | ? |
|
| fluentd | ? |
|
| foundationdb | ? |
|
| gearmand | ? |
|
| gitlab | ? |
|
| gitlab_runner | ? |
|
| glusterfs | ? |
|
| go_expvar | ? |
|
| gunicorn | ? |
|
| haproxy | ? |
|
| harbor | ? |
|
| hazelcast | ? |
|
| hdfs_datanode | ? |
|
| hdfs_namenode | ? |
|
| http_check | ? |
|
| ibm_ace | ? |
|
| ibm_db2 | ? |
|
| ibm_i | ? |
|
| ibm_mq | ? |
|
| ibm_was | ? |
|
| iis | ? |
|
| impala | ? |
|
| istio | ? |
|
| kafka_consumer | ? |
|
| kong | ? |
|
| kube_apiserver_metrics | ? |
|
| kube_controller_manager | ? |
|
| kube_dns | ? |
|
| kube_metrics_server | ? |
|
| kube_proxy | ? |
|
| kube_scheduler | ? |
|
| kubelet | ? |
|
| kubernetes_state | ? |
|
| kyototycoon | ? |
|
| lighttpd | ? |
|
| linkerd | ? |
|
| linux_proc_extras | ? |
|
| mapr | ? |
|
| mapreduce | ? |
|
| marathon | ? |
|
| marklogic | ? |
|
| mcache | ? |
|
| mesos_master | ? |
|
| mesos_slave | ? |
|
| mongo | ? |
|
| mysql | ? |
|
| nagios | ? |
|
| network | ? |
|
| nfsstat | ? |
|
| nginx | ? |
|
| nginx_ingress_controller | ? |
|
| openldap | ? |
|
| openmetrics | ? |
|
| openstack | ? |
|
| openstack_controller | ? |
|
| oracle | ? |
|
| pdh_check | ? |
|
| pgbouncer | ? |
|
| php_fpm | ? |
|
| postfix | ? |
|
| postgres | ? |
|
| powerdns_recursor | ? |
|
| process | ? |
|
| prometheus | ? |
|
| proxysql | ? |
|
| pulsar | ? |
|
| rabbitmq | ? |
|
| redisdb | ? |
|
| rethinkdb | ? |
|
| riak | ? |
|
| riakcs | ? |
|
| sap_hana | ? |
|
| scylla | ? |
|
| silk | ? |
|
| singlestore | ? |
|
| snmp | ? |
|
| snowflake | ? |
|
| sonarqube | ? |
|
| spark | ? |
|
| squid | ? |
|
| ssh_check | ? |
|
| statsd | ? |
|
| supervisord | ? |
|
| system_core | ? |
|
| system_swap | ? |
|
| tcp_check | ? |
|
| teamcity | 88.21% <87.76%> (+8.21%) |
:arrow_up: |
| teradata | ? |
|
| tls | ? |
|
| traffic_server | ? |
|
| twemproxy | ? |
|
| twistlock | ? |
|
| varnish | ? |
|
| vault | ? |
|
| vertica | ? |
|
| voltdb | ? |
|
| vsphere | ? |
|
| win32_event_log | ? |
|
| windows_performance_counters | ? |
|
| windows_service | ? |
|
| wmi_check | ? |
|
| yarn | ? |
|
| zk | ? |
Flags with carried forward coverage won't be shown. Click here to find out more.
![codecov[bot] avatar](https://avatars.githubusercontent.com/in/254?v=4 "Published by a pub.dev verified publisher"){kind=small}
Also I just added a changelog/Added label since it seems to be compatible with the previous version of the check. Feel free to change this to changelog/Changed if that is more suitable!
@buraizu
Would you be able to review the metrics listed in the metadata.csv file, or otherwise let me know if it's alright for me to do so?
Sure, feel free to review the metadata.csv file, thanks! I'll review it as well with your suggestions in mind and make any corrections
The validations job has failed; please review the Files changed tab for possible suggestions to resolve.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
The validations job has failed; please review the Files changed tab for possible suggestions to resolve.
For references to the Datadog Agent, agent should be capitalized -- not sure if every use of agent is the Datadog Agent in this case, could you confirm?
The use of agent in the metadata.csv are referring to TeamCity build agents, not the Datadog Agent.
There's no description for teamcity.server_side_build_finishing
I haven't been able to find a documented description for this metric
Also I just added a changelog/Added label since it seems to be compatible with the previous version of the check. Feel free to change this to changelog/Changed if that is more suitable!
I think the change is big enough for it to be a new major even if it does not break compatibility
Label changelog/Changed was added to this Pull Request, so the next release will bump major version. Please make sure this is a breaking change, or use the changelog/Fixed label.