integrations-core icon indicating copy to clipboard operation
integrations-core copied to clipboard

improve win32_event_log docs

Open ian28223 opened this issue 2 years ago • 4 comments

What does this PR do?

Updates the documentation to make it clear that config under instances: (collected as DD Events) are mutually exclusive to config under logs: (collected as DD Logs)

Motivation

Users often confuse the 2 thinking both configs are needed or certain filter parameters get mixed in irrelevant sections of the configuration.

Additional Notes

  • Not sure how to preview the doc with tabs so I was not able to check how this would render

Review checklist (to be filled by reviewers)

  • [ ] Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • [ ] PR title must be written as a CHANGELOG entry (see why)
  • [ ] Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • [ ] PR must have changelog/ and integration/ labels attached

ian28223 avatar Aug 16 '22 03:08 ian28223

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

github-actions[bot] avatar Aug 16 '22 03:08 github-actions[bot]

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

github-actions[bot] avatar Aug 16 '22 06:08 github-actions[bot]

@ian28223 you'll need to merge master into this branch or rebase to fix the CI

FlorentClarret avatar Sep 14 '22 07:09 FlorentClarret

Rebased and resolved conflicts. Kindly re-review 🙇

ian28223 avatar Oct 26 '22 04:10 ian28223