integrations-core icon indicating copy to clipboard operation
integrations-core copied to clipboard

Assert all metrics are emitted and that metadata is correct

Open hithwen opened this issue 2 years ago • 6 comments

QA for https://github.com/DataDog/integrations-core/pull/12104/files This PR introduces assertion for all metrics covered and all metrics in metadata.

With the first assertion I've introduced tons of optional metrics (some might be missing and thus cause flakeyness in the near future) but it is the only way to be able to then do the second assertion and ensure we are not missing anything on the metadata file (we are).

hithwen avatar Aug 10 '22 10:08 hithwen

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

github-actions[bot] avatar Aug 10 '22 11:08 github-actions[bot]

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

github-actions[bot] avatar Aug 10 '22 11:08 github-actions[bot]

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

github-actions[bot] avatar Aug 10 '22 12:08 github-actions[bot]

Codecov Report

Merging #12724 (10a3539) into master (3780660) will decrease coverage by 0.00%. The diff coverage is 100.00%.

Flag Coverage Δ
clickhouse 95.31% <100.00%> (-0.32%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

codecov[bot] avatar Aug 10 '22 12:08 codecov[bot]

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

github-actions[bot] avatar Aug 10 '22 13:08 github-actions[bot]

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

github-actions[bot] avatar Aug 10 '22 13:08 github-actions[bot]

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

github-actions[bot] avatar Aug 16 '22 11:08 github-actions[bot]

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

github-actions[bot] avatar Aug 16 '22 11:08 github-actions[bot]