integrations-core icon indicating copy to clipboard operation
integrations-core copied to clipboard

Add the Impala integration

Open FlorentClarret opened this issue 3 years ago • 1 comments

What does this PR do?

Motivation

Additional Notes

Review checklist (to be filled by reviewers)

  • [ ] Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • [ ] PR title must be written as a CHANGELOG entry (see why)
  • [ ] Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • [ ] PR must have changelog/ and integration/ labels attached

FlorentClarret avatar Jul 20 '22 09:07 FlorentClarret

Codecov Report

Merging #12548 (95e00e7) into master (99ab510) will increase coverage by 0.07%. The diff coverage is 97.78%.

:exclamation: Current head 95e00e7 differs from pull request most recent head e00192d. Consider uploading reports for the commit e00192d to get more accurate results

Flag Coverage Δ
cert_manager ?
impala 97.78% <97.78%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

codecov[bot] avatar Jul 21 '22 13:07 codecov[bot]

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

github-actions[bot] avatar Aug 16 '22 08:08 github-actions[bot]

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

github-actions[bot] avatar Aug 22 '22 09:08 github-actions[bot]

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

github-actions[bot] avatar Aug 22 '22 12:08 github-actions[bot]

Created DOCS-3968 for docs review.

maycmlee avatar Aug 22 '22 17:08 maycmlee

Thanks @buraizu for the review! I modified all the files except the conf.yaml.example one because this one is auto-generated.

Since we will also have to update the -extras and marketplace integrations because of these changes, I created three separate tickets (because the changes you requested belong to three different type of integrations)

  • AI-2646 for openmetrics
  • AI-2647 for http
  • AI-2648 for the global instances config

Resolving all the comments that relates to this modifications

FlorentClarret avatar Aug 23 '22 07:08 FlorentClarret

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

github-actions[bot] avatar Sep 12 '22 09:09 github-actions[bot]

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

github-actions[bot] avatar Sep 12 '22 09:09 github-actions[bot]