integrations-core icon indicating copy to clipboard operation
integrations-core copied to clipboard

Add metrics to metadata

Open yzhan289 opened this issue 2 years ago • 1 comments

What does this PR do?

This PR updates the metadata.csv to include metrics added in https://github.com/DataDog/integrations-core/pull/12352

Motivation

QA for https://github.com/DataDog/integrations-core/pull/12352

Additional Notes

Review checklist (to be filled by reviewers)

  • [ ] Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • [ ] PR title must be written as a CHANGELOG entry (see why)
  • [ ] Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • [ ] PR must have changelog/ and integration/ labels attached

yzhan289 avatar Jun 28 '22 12:06 yzhan289

@alopezz

It looks to me like it's the versions without the .count that need clarifying?

~~True, I think saying The number of... in the description can make it seem like the metric should be a count. I can change it so only gauge metrics with new *.count versions are updated.~~

After looking into this more, every metric has The number of... in the description, so I think it would actually make more sense to modify the new *.count versions still, since customers may be used to associating "number" with gauge.

yzhan289 avatar Jul 05 '22 17:07 yzhan289

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

github-actions[bot] avatar Aug 15 '22 20:08 github-actions[bot]

Merging because this validations issue is due to the new packaging dependency being added. This is fixed here: https://github.com/DataDog/integrations-core/pull/12753

yzhan289 avatar Aug 16 '22 17:08 yzhan289

I'm a bit late to the party and it's not a big deal but since these metrics have .count in the name isnt it a bit redundat to say it in the description too?

hithwen avatar Sep 20 '22 11:09 hithwen