integrations-core icon indicating copy to clipboard operation
integrations-core copied to clipboard

postgres: Allow ignore_databases config option to be empty

Open xcoderzach opened this issue 3 years ago • 1 comments

What does this PR do?

This fixes a bug where setting ignore_databases: [] in the config would generate a broken query.

Motivation

A client is using databases that we typically ignore, and would like to monitor them.

Additional Notes

TODO: I'm not sure where the best place to add a test for this is.

Review checklist (to be filled by reviewers)

  • [ ] Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • [ ] PR title must be written as a CHANGELOG entry (see why)
  • [ ] Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • [ ] PR must have changelog/ and integration/ labels attached

xcoderzach avatar May 13 '22 05:05 xcoderzach

Codecov Report

Merging #12021 (1361e8d) into master (caab6f6) will increase coverage by 0.01%. Report is 3354 commits behind head on master. The diff coverage is 100.00%.

Flag Coverage Δ
postgres 92.09% <100.00%> (+0.42%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

codecov[bot] avatar May 13 '22 06:05 codecov[bot]

Closing this PR since it's still a draft, feel free to re-open it if needed 🙂

FlorentClarret avatar Jan 03 '24 07:01 FlorentClarret