integrations-core
integrations-core copied to clipboard
Discover and validate defined projects
What does this PR do?
- Discovers available projects/components and logs them at debug level.
- Logs a warning if projects/components defined in config were not found.
Motivation
- As of current, if an invalid project/component is specified, the integration does not return any metrics and no indication why. Looking in the logs, we get an HTTP error 404
- AGENT-7116
Additional Notes
- List of available components is queried from the API and is logged on debug mode
Review checklist (to be filled by reviewers)
- [ ] Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
- [ ] PR title must be written as a CHANGELOG entry (see why)
- [ ] Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
- [ ] PR must have
changelog/
andintegration/
labels attached
Isn't it a bit overkill to add a config option for this? Shouldn't it always log with self.log.warning
? I'm not sure how much visibility self.warning
provides tbh
The validations
job has failed; please review the Files changed
tab for possible suggestions to resolve.
Codecov Report
Merging #11171 (d86020e) into master (ca15693) will decrease coverage by
1.46%
. The diff coverage is91.11%
.
:exclamation: Current head d86020e differs from pull request most recent head 7507ad0. Consider uploading reports for the commit 7507ad0 to get more accurate results
Flag | Coverage Δ | |
---|---|---|
arangodb | ? |
|
boundary | ? |
|
ddev | ? |
|
sonarqube | 95.78% <91.11%> (+0.09%) |
:arrow_up: |
teradata | ? |
|
traffic_server | ? |
Flags with carried forward coverage won't be shown. Click here to find out more.
replaced by #13450