glommio icon indicating copy to clipboard operation
glommio copied to clipboard

Merge common impls of `submit_one_event` into `submit_event_chain`

Open vmingchen opened this issue 3 years ago • 3 comments

What does this PR do?

Address https://github.com/DataDog/glommio/issues/548

Motivation

Refactor code to reduce code duplication.

Related issues

A list of issues either fixed, containing architectural discussions, otherwise relevant for this Pull Request.

Additional Notes

Pure refactoring; no behavior change.

Checklist

[] I have added unit tests to the code I am submitting [] My unit tests cover both failure and success scenarios [] If applicable, I have discussed my architecture

vmingchen avatar Apr 18 '22 19:04 vmingchen

Hey @vmingchen -- In the future, can you either fill out the pull request template or at least delete it (if it's not relevant, though that's also debatable..)? It was surprising to come read this and realize it was just the template unchanged.

bryandmc avatar Apr 30 '22 21:04 bryandmc

Hey @vmingchen -- In the future, can you either fill out the pull request template or at least delete it (if it's not relevant, though that's also debatable..)? It was surprising to come read this and realize it was just the template unchanged.

Sorry about that. Edited the PR description.

vmingchen avatar May 06 '22 15:05 vmingchen

anything missing for merging this ?

glommer avatar Jul 18 '22 01:07 glommer