glommio icon indicating copy to clipboard operation
glommio copied to clipboard

Tests in timer/timer_impl.rs are time sensitive and can be flaky

Open vmingchen opened this issue 2 years ago • 1 comments

These tests cover the Timer API, so they are sensitive to timing and can be flaky if the dev environment changes. We need to make them more robust.

vmingchen avatar Apr 06 '22 23:04 vmingchen

Fully Agree.

Usually the way to make it work is to have a parametrized clock implementation that defaults to wallclock, but for tests you can pass your own that you can manually control.

glommer avatar Apr 06 '22 23:04 glommer