ddprof icon indicating copy to clipboard operation
ddprof copied to clipboard

[PROF-9088] Consider timestamps in comm and fork events

Open r1viollet opened this issue 1 year ago • 2 comments

What does this PR do?

To prevent clearing mmap data when it is not useful, we consider timestamps of comm and fork events.

Motivation

We encountered an issue where we gather mmap data just prior to a comm event. The comm event clears the data. Then we are unable to compute the offset from an elf file.

Additional Notes

NA

How to test the change?

I added a unit test. I will check with user if this fixes the issue he encountered or if we need to go further.

r1viollet avatar Jan 23 '24 09:01 r1viollet

Benchmark results for collatz

Parameters

Baseline Candidate
config baseline candidate
profiler-version ddprof 0.15.3+a078c6cd.27241841 ddprof 0.15.3+a521115d.27247464

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 1 metrics, 0 unstable metrics.

See unchanged results
scenario Δ mean execution_time
scenario:ddprof -S bench-collatz --preset cpu_only collatz_runner.sh same

pr-commenter[bot] avatar Jan 23 '24 10:01 pr-commenter[bot]

Benchmark results for BadBoggleSolver_run

Parameters

Baseline Candidate
config baseline candidate
profiler-version ddprof 0.15.3+a078c6cd.27241841 ddprof 0.15.3+a521115d.27247464

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 1 metrics, 0 unstable metrics.

See unchanged results
scenario Δ mean execution_time
scenario:ddprof -S bench-bad-boggle-solver BadBoggleSolver_run work 1000 same

pr-commenter[bot] avatar Jan 23 '24 10:01 pr-commenter[bot]