ddprof icon indicating copy to clipboard operation
ddprof copied to clipboard

Sanchda/singleton watchers

Open sanchda opened this issue 1 year ago • 0 comments

This is not ready for review, but if you wanna look, you can.

OK, so I wrote this on the plane ride from Paris without being able to compile it since my docker was broken, so it needs a lot of work, but the idea is to refactor our perf event management.

The reason for this: right now it's hard to extend things and we have a few upcoming needs

  • Multiplex ringbuffers (handled in this PR, although globally)
  • Scrape sample IDs (handled in this PR)
  • Better management of multiple watchers (not handled here, but this should make it easier I hope???)

What does this PR do?

A brief description of the change being made with this pull request.

Motivation

What inspired you to submit this pull request? In order to motivate your point, it may be valuable to explain why this change is useful or what problem is being solved.

Additional Notes

This is the section to put technical guidance/constraints, call out potential regressions, cite sources, and in general offer some exposition on the how of the PR. This section doesn't need to be incredibly detailed, but it makes life easier for reviewers!

How to test the change?

Describe here in detail how the change can be validated. This is a great section to call out specific tests you've added or improved, or to acknowledge code sections which are particularly difficult to test.

sanchda avatar Oct 25 '23 20:10 sanchda