dd-trace-rb icon indicating copy to clipboard operation
dd-trace-rb copied to clipboard

[NO-TICKET] Update redis container to redis 8

Open vpellan opened this issue 6 months ago • 2 comments

What does this PR do?

This PR update redis container to redis 8, and activate Sidekiq tests.

Motivation:

Sidekiq tests are failing locally (in container environment) as it requires redis 7 at least.

Change log entry

none.

Additional Notes:

How to test the change?

CI / locally, in container, using bundle exec rake test:sidekiq

vpellan avatar Jul 10 '25 10:07 vpellan

Benchmarks

Benchmark execution time: 2025-07-16 12:05:06

Comparing candidate commit 4696a6f0819c6ccea00aabfbc565f60b8271bff3 in PR branch vpellan/update-redis-to-8 with baseline commit 633b084b2808c1c5a3141b93f5adebadde7d8737 in branch master.

Found 1 performance improvements and 1 performance regressions! Performance is the same for 42 metrics, 5 unstable metrics.

scenario:error - error tracking with http - third_party only

  • 🟥 throughput [-86.277op/s; -72.287op/s] or [-60.652%; -50.818%]

scenario:tracing - trace.to_digest

  • 🟩 throughput [+7586.046op/s; +8117.134op/s] or [+5.559%; +5.949%]

pr-commenter[bot] avatar Jul 10 '25 10:07 pr-commenter[bot]

Noticed this PR has been around for a while -- is it still relevant or should we close it?

ivoanjo avatar Nov 20 '25 13:11 ivoanjo