dd-trace-rb
dd-trace-rb copied to clipboard
Update to libddwaf v1.24.1 to adopt per-config error reporting
What does this PR do?
This PR updates libddwaf-rb to 1.24.1 and changes the way how the Remote Config changes are handled.
Motivation: We want to report errors for separately for each Remote Config configuration.
Change log entry
Yes. Deprecate config.appsec.ip_passlist, config.appsec.ip_denylist, and config.appsec.user_id_denylist.
Additional Notes: Only the ruby library supports configuration of allow- and denylists directly via library configuration. Other libraries only configure it using Remote Configuration. This is why we are deprecating it.
Related system-tests PR: https://github.com/DataDog/system-tests/pull/4807
How to test the change? CI and manual testing with app-generator.
Datadog Report
Branch report: update-libddwaf-to-1-24-1
Commit report: 6f64657
Test service: dd-trace-rb
:white_check_mark: 0 Failed, 21584 Passed, 1284 Skipped, 4m 53.3s Total Time
Benchmarks
Benchmark execution time: 2025-06-30 14:45:14
Comparing candidate commit 4d5a362a819e7039da68c4ffd0350a0e221cac1d in PR branch update-libddwaf-to-1-24-1 with baseline commit 9a889061676d5d257de149ec68b56805aab390f3 in branch master.
Found 2 performance improvements and 0 performance regressions! Performance is the same for 41 metrics, 6 unstable metrics.
scenario:line instrumentation - targeted
- 🟩
throughput[+11985.914op/s; +12530.364op/s] or [+7.600%; +7.945%]
scenario:method instrumentation
- 🟩
throughput[+14145.689op/s; +14727.301op/s] or [+8.475%; +8.823%]
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 97.53%. Comparing base (
9a88906) to head (4d5a362).
Additional details and impacted files
@@ Coverage Diff @@
## master #4757 +/- ##
==========================================
- Coverage 97.56% 97.53% -0.03%
==========================================
Files 1486 1484 -2
Lines 88716 88401 -315
Branches 4599 4581 -18
==========================================
- Hits 86552 86224 -328
- Misses 2164 2177 +13
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
- :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.