dd-trace-rb icon indicating copy to clipboard operation
dd-trace-rb copied to clipboard

graphql-root-span-resource

Open marcotc opened this issue 6 months ago • 3 comments

Set top level span to GraphQL query type and name.

What does this PR do?

Motivation:

Change log entry

Additional Notes:

How to test the change?

marcotc avatar May 06 '25 22:05 marcotc

:wave: Hey @marcotc, please fill "Change log entry" section in the pull request description.

If changes need to be present in CHANGELOG.md you can state it this way

**Change log entry**

Yes. A brief summary to be placed into the CHANGELOG.md

(possible answers Yes/Yep/Yeah)

Or you can opt out like that

**Change log entry**

None.

(possible answers No/Nope/None)

Visited at: 2025-05-06 22:01:00 UTC

github-actions[bot] avatar May 06 '25 22:05 github-actions[bot]

Benchmarks

Benchmark execution time: 2025-05-06 22:19:18

Comparing candidate commit 05de2ff9246edcd8efe901de8c0d01a51096b0ef in PR branch graphql-root-span-resource with baseline commit 1b96ec83544defc1797687b89e4fcd250e783231 in branch master.

Found 2 performance improvements and 0 performance regressions! Performance is the same for 29 metrics, 2 unstable metrics.

scenario:profiler - Allocations (profiling disabled)

  • 🟩 throughput [+448271.297op/s; +454575.814op/s] or [+9.652%; +9.788%]

scenario:profiler - Allocations (profiling enabled)

  • 🟩 throughput [+447905.365op/s; +457437.552op/s] or [+9.737%; +9.945%]

pr-commenter[bot] avatar May 06 '25 22:05 pr-commenter[bot]

Datadog Report

Branch report: graphql-root-span-resource Commit report: 05de2ff Test service: dd-trace-rb

:x: 1 Failed (0 Known Flaky), 20887 Passed, 1368 Skipped, 3m 36.8s Total Time

:x: Failed Tests (1)

  • Rails Rack span resource a custom controller span resource is applied propagates the custom controller span resource to the request span resource - rspec - Details

    Expand for error
    xpected: "CustomSpanResource"
        got: "TestController#custom_span_resource"
    
    compared using ==)
    
    ailure/Error: expect(trace.resource).to eq('CustomSpanResource')
    
     expected: "CustomSpanResource"
          got: "TestController#custom_span_resource"
    
    ..