dd-trace-rb icon indicating copy to clipboard operation
dd-trace-rb copied to clipboard

Fix test with swallowed errors

Open marcotc opened this issue 10 months ago • 4 comments

What does this PR do?

Motivation:

Change log entry

Additional Notes:

How to test the change?

marcotc avatar Jan 23 '25 23:01 marcotc

:wave: Hey @marcotc, please fill "Change log entry" section in the pull request description.

If changes need to be present in CHANGELOG.md you can state it this way

**Change log entry**

Yes. A brief summary to be placed into the CHANGELOG.md

(possible answers Yes/Yep/Yeah)

Or you can opt out like that

**Change log entry**

None.

(possible answers No/Nope/None)

Visited at: 2025-01-23 23:53:29 UTC

github-actions[bot] avatar Jan 23 '25 23:01 github-actions[bot]

Datadog Report

Branch report: warn-test Commit report: 908f73c Test service: dd-trace-rb

:white_check_mark: 0 Failed, 22012 Passed, 1477 Skipped, 5m 11.86s Total Time

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 97.72%. Comparing base (84ca739) to head (908f73c). Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4317      +/-   ##
==========================================
- Coverage   97.72%   97.72%   -0.01%     
==========================================
  Files        1365     1365              
  Lines       82727    82730       +3     
  Branches     4205     4205              
==========================================
+ Hits        80846    80848       +2     
- Misses       1881     1882       +1     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Jan 24 '25 00:01 codecov-commenter

Benchmarks

Benchmark execution time: 2025-01-24 00:15:51

Comparing candidate commit 908f73c1f55b582fa29e879afb230ae37f58119e in PR branch warn-test with baseline commit 84ca739d8a6183def44b2592f3dcf1829bdfdc7c in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 31 metrics, 2 unstable metrics.

pr-commenter[bot] avatar Jan 24 '25 00:01 pr-commenter[bot]