dd-trace-rb icon indicating copy to clipboard operation
dd-trace-rb copied to clipboard

Update Span and SpanOperation pretty print

Open marcotc opened this issue 10 months ago • 4 comments

What does this PR do?

Motivation:

Change log entry

Additional Notes:

How to test the change?

marcotc avatar Jan 09 '25 23:01 marcotc

:wave: Hey @marcotc, please fill "Change log entry" section in the pull request description.

If changes need to be present in CHANGELOG.md you can state it this way

**Change log entry**

Yes. A brief summary to be placed into the CHANGELOG.md

(possible answers Yes/Yep/Yeah)

Or you can opt out like that

**Change log entry**

None.

(possible answers No/Nope/None)

Visited at: 2025-01-09 23:18:37 UTC

github-actions[bot] avatar Jan 09 '25 23:01 github-actions[bot]

Datadog Report

Branch report: better-print Commit report: 852c92d Test service: dd-trace-rb

:white_check_mark: 0 Failed, 22117 Passed, 1476 Skipped, 5m 51.02s Total Time

Codecov Report

Attention: Patch coverage is 84.70588% with 13 lines in your changes missing coverage. Please review.

Project coverage is 97.73%. Comparing base (aff0f7c) to head (852c92d).

Files with missing lines Patch % Lines
lib/datadog/tracing/span_event.rb 45.45% 6 Missing :warning:
lib/datadog/tracing/span_link.rb 57.14% 6 Missing :warning:
lib/datadog/tracing/span.rb 97.95% 1 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4273      +/-   ##
==========================================
- Coverage   97.73%   97.73%   -0.01%     
==========================================
  Files        1354     1354              
  Lines       82449    82484      +35     
  Branches     4236     4249      +13     
==========================================
+ Hits        80584    80614      +30     
- Misses       1865     1870       +5     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Jan 09 '25 23:01 codecov-commenter

Benchmarks

Benchmark execution time: 2025-01-09 23:31:56

Comparing candidate commit 852c92d3812972fb56f1e7f67d7044430f124030 in PR branch better-print with baseline commit aff0f7c71b0bb045c4af3e8f34782ca6addf7bcc in branch master.

Found 1 performance improvements and 0 performance regressions! Performance is the same for 30 metrics, 2 unstable metrics.

scenario:profiler - profiler gc

  • 🟩 throughput [+16003.055op/s; +16523.006op/s] or [+5.594%; +5.776%]

pr-commenter[bot] avatar Jan 09 '25 23:01 pr-commenter[bot]