dd-trace-rb icon indicating copy to clipboard operation
dd-trace-rb copied to clipboard

[FEATURE]: Option to disable incompatible Lograge setup

Open marcotc opened this issue 1 year ago • 2 comments

Gem Name

lograge

Gem Version(s)

any

Describe the goal of the feature

In #3839 we added a log message to alert users when an incompatible lograge setup is present.

But because this incompatibility with lograge has been around for quite some time, users have come up with workarounds for it in their code bases.

We should provide an option to disable this log message.

Is your feature request related to a problem?

No response

Describe alternatives you've considered

No response

Additional context

No response

marcotc avatar Jan 08 '25 18:01 marcotc

Something to add to this work - Datadog's docs recommend using lograge for Rails applications. If there's an incompatibility, it should be addressed by changing those docs as well.

See https://www.datadoghq.com/blog/monitoring-rails-with-datadog/#fine-tuning-your-rails-logs

Lograge is a popular library for Rails applications as it converts multi-line request logs to JSON format and provides custom formatting options. You can also use other libraries such as Log4r and Logging to format your application logs, though Lograge is specifically designed for use with Rails applications.

chrismanderson avatar Jan 28 '25 22:01 chrismanderson

Ooops, thanks for pointing that out! Will get in touch with the docs team :)

ivoanjo avatar Jan 29 '25 09:01 ivoanjo