dd-trace-rb icon indicating copy to clipboard operation
dd-trace-rb copied to clipboard

Safely merge options

Open marcotc opened this issue 1 year ago • 3 comments

What does this PR do? Provides a way for configuration overrides to be reliably merged and validated.

Change log entry

Additional Notes:

How to test the change?

marcotc avatar Dec 09 '24 23:12 marcotc

:wave: Hey @marcotc, please fill "Change log entry" section in the pull request description.

If changes need to be present in CHANGELOG.md you can state it this way

**Change log entry**

Yes. A brief summary to be placed into the CHANGELOG.md

(possible answers Yes/Yep/Yeah)

Or you can opt out like that

**Change log entry**

None.

(possible answers No/Nope/None)

Visited at: 2024-12-09 23:47:53 UTC

github-actions[bot] avatar Dec 09 '24 23:12 github-actions[bot]

Benchmarks

Benchmark execution time: 2024-12-10 00:10:09

Comparing candidate commit 4d554d5e9165547b171a08f65cfdcd8f2fa63dbe in PR branch merge-options-safe with baseline commit dc553017551255e8497e0b6f836a7c1ddcf7c7ea in branch master.

Found 0 performance improvements and 1 performance regressions! Performance is the same for 30 metrics, 2 unstable metrics.

scenario:profiler - sample timeline=false

  • 🟥 throughput [-0.693op/s; -0.683op/s] or [-10.519%; -10.358%]

pr-commenter[bot] avatar Dec 10 '24 00:12 pr-commenter[bot]

Hey, is this PR still relevant?

ivoanjo avatar Nov 27 '25 09:11 ivoanjo