dd-trace-rb icon indicating copy to clipboard operation
dd-trace-rb copied to clipboard

Add lib injection support for Ruby 3.3

Open marcotc opened this issue 1 year ago • 4 comments
trafficstars

Support for Ruby 3.3 is present in the gem, the only thing needed for injection is to change the installation script to allow it to run with that version of Ruby.

Because the Ruby API does not change in incompatible ways in between patch versions, we declare our compatibility with the API version "3.3.0", thus supporting all 3.3.x versions.

How to test the change?

Unsure? Have a question? Request a review!

marcotc avatar Oct 15 '24 16:10 marcotc

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 97.85%. Comparing base (38f6cc1) to head (0c22662).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4001      +/-   ##
==========================================
- Coverage   97.86%   97.85%   -0.01%     
==========================================
  Files        1319     1319              
  Lines       79144    79144              
  Branches     3927     3927              
==========================================
- Hits        77451    77446       -5     
- Misses       1693     1698       +5     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Oct 15 '24 17:10 codecov-commenter

Benchmarks

Benchmark execution time: 2024-10-22 17:23:00

Comparing candidate commit 0c22662a2d94cfdee8bfe374cb1aee11246090c7 in PR branch marcotc/lilbinj-3.3.0 with baseline commit 38f6cc14918d9c21312f786dcc6693432ba11fdf in branch master.

Found 0 performance improvements and 1 performance regressions! Performance is the same for 23 metrics, 2 unstable metrics.

scenario:profiler - sample timeline=false

  • 🟥 throughput [-0.803op/s; -0.792op/s] or [-11.691%; -11.524%]

pr-commenter[bot] avatar Oct 15 '24 17:10 pr-commenter[bot]

@TonyCTHsu

Need a custom Ruby 3.3 image to build gems in a static way

Where are these images stored?

marcotc avatar Oct 18 '24 19:10 marcotc

Where are these images stored?

Afaik the dockerfiles are those in https://github.com/DataDog/dd-trace-rb/tree/master/.gitlab . I'm not sure how the rest of the pipeline is set up.

It may be worth documenting this somewhere? E.g. so it's clear how we can every year add new Ruby versions for the injection.

ivoanjo avatar Oct 23 '24 08:10 ivoanjo

Obsolete by: https://github.com/DataDog/dd-trace-rb/pull/4137

TonyCTHsu avatar Nov 21 '24 13:11 TonyCTHsu