dd-trace-rb icon indicating copy to clipboard operation
dd-trace-rb copied to clipboard

GRPC integration logging error even when tracing is disabled

Open sco11morgan opened this issue 8 months ago • 2 comments

Current behaviour

GRPC integration logging error even when tracing is disabled. These errors are logged locally when running tests with tracing disabled.

E, [2024-06-18T14:45:33.966658 #817] ERROR -- ddtrace: [ddtrace] (/usr/local/bundle/ruby/3.1.0/gems/ddtrace-1.23.0/lib/datadog/tracing/distributed/propagation.rb:65:in `rescue in block in inject!') Error injecting distributed trace data. Cause: can't convert nil into Integer Location: /usr/local/bundle/ruby/3.1.0/gems/ddtrace-1.23.0/lib/datadog/tracing/distributed/trace_context.rb:124:in `format'

Expected behaviour

With tracing is disabled we'd expect no error logged.

As a workaround we are explicitly skipping the integration with

  c.tracing.instrument :grpc if Rails.env.production? || Rails.env.qa?

and that stops the errors from showing.

Environment

  • datadog version: 1.23.0
  • Configuration block (Datadog.configure ...):
Datadog.configure do |c|
  
  c.tracing.enabled = Rails.env.production? || Rails.env.qa?
  c.tracing.analytics.enabled = Rails.env.production? || Rails.env.qa?
  c.tracing.instrument :grpc
end
  • Ruby version: 3.1.5
  • Operating system: Debian Bullseye
  • Relevant library versions:

sco11morgan avatar Jun 18 '24 21:06 sco11morgan