dd-trace-rb icon indicating copy to clipboard operation
dd-trace-rb copied to clipboard

Published 20 hours ago • verified publisher icon DataDog

http connect tracing

Open dpep opened this issue 1 year ago • 2 comments

What does this PR do? trace http connections, in addition to the already existing request traces

Motivation https://github.com/DataDog/dd-trace-rb/issues/2838

How to test the change?

image

image

image

dpep avatar May 15 '23 20:05 dpep

@dpep Thank you so much for the contribution 🎉

The code looks sane to me. Still, I would refer to anyone from tracing to have a look before approving it @marcotc @TonyCTHsu

Also, would it be possible to add unit tests for the new span?

GustavoCaso avatar May 19 '23 12:05 GustavoCaso

@TonyCTHsu @GustavoCaso @dpep I will take a look at this.

delner avatar May 30 '23 14:05 delner