dd-trace-rb icon indicating copy to clipboard operation
dd-trace-rb copied to clipboard

Sampling-Propagation:Exclude problematic existing tag

Open marcotc opened this issue 2 years ago • 1 comments

The distributed tracing tag _dd.p.upstream_services was at one point populated by other language traces, but can contain privileged information that can leak to third party services when injected in a distributed context.

Although the Ruby tracer has never populated this tag, we must make sure we don't propagate this tag downstream if we ever receive it in a distributed tracing request context.

marcotc avatar Sep 28 '22 23:09 marcotc

Codecov Report

Merging #2299 (cf147d8) into sampling-dm-propagation (a0670e4) will increase coverage by 0.00%. The diff coverage is 100.00%.

@@                   Coverage Diff                    @@
##           sampling-dm-propagation    #2299   +/-   ##
========================================================
  Coverage                    98.34%   98.34%           
========================================================
  Files                         1102     1102           
  Lines                        58856    58865    +9     
========================================================
+ Hits                         57879    57890   +11     
+ Misses                         977      975    -2     
Impacted Files Coverage Δ
lib/datadog/tracing/distributed/headers/datadog.rb 100.00% <100.00%> (ø)
...atadog/tracing/distributed/headers/datadog_spec.rb 100.00% <100.00%> (ø)
lib/datadog/core/diagnostics/environment_logger.rb 100.00% <0.00%> (+1.57%) :arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov-commenter avatar Sep 29 '22 00:09 codecov-commenter