dd-trace-rb
dd-trace-rb copied to clipboard
DataDog
Add unobtrusive method tracing
Sorry for the delay here in reviewing. Generally I think this is a good approach and we appreciate the contribution, and if i'm understanding the implementation correctly, we're successfully avoiding the pitfall mentioned here by only prepending the Container module once https://github.com/DataDog/dd-trace-rb/pull/1215/files#diff-ccf38a2ec0604d3bdf40d8ed352af6fca58d18fcf29578f82c5b0c5155b4a864R58-R59. It would be good to get a second set of eyes on this I will try to have one of my colleagues take a look as well.
Thank you so much for the updates, @norbertnytko. I'll take another thorough look at the new changes soon.
@norbertnytko thank you so much for this PR! We think that this is the most polished and clean implementation of a tracer mixin to date 🎉.
There are finishing touches we'd like to have shipped with the tracer mixin (e.g. documentation, a way to provide options to the created span, review module/method naming convention), but most of these require close coordination with the internal team.
At this time, because our internal priorities are in alignment with the work you've done here, we're taking the responsibility of addressing these last changes and getting your work merged.
I'm continuing this work in another PR here: #1348. I would love to hear your feedback when it's all finally done, to ensure that we are addressing the exact use case you have.
Again, thank you so much for all the help! 🙇