dd-trace-py
dd-trace-py copied to clipboard
feat(asm): grpc threats support
Description
Add Threat Monitoring support for gRPC (first part, without blocking).
Checklist
- [X] The PR description includes an overview of the change
- [X] The PR description articulates the motivation for the change
- [X] The change includes tests OR the PR description describes a testing strategy
- [X] The PR description notes risks associated with the change, if any
- [X] Newly-added code is easy to change
- [X] The change follows the library release note guidelines
- [X] The change includes or references documentation updates if necessary
- [X] Backport labels are set (if applicable)
Reviewer Checklist
- [ ] Title is accurate
- [ ] All changes are related to the pull request's stated goal
- [ ] Avoids breaking API changes
- [ ] Testing strategy adequately addresses listed risks
- [ ] Newly-added code is easy to change
- [ ] Release note makes sense to a user of the library
- [ ] If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
- [ ] Backport labels are set in a manner that is consistent with the release branch maintenance policy
Datadog Report
Branch report: juanjux/APPSEC-52949-grpc-threats-support
Commit report: 2e39d58
Test service: dd-trace-py
:white_check_mark: 0 Failed, 111167 Passed, 3472 Skipped, 11m 19.82s Total duration (46m 15.14s time saved)
Benchmarks
Benchmark execution time: 2024-07-08 17:21:11
Comparing candidate commit 86dbdd6da3edf64f72701b5ccd67028a8501c0d0 in PR branch juanjux/APPSEC-52949-grpc-threats-support with baseline commit 41014bd9392c865e44c90939554894dcce57aa47 in branch main.
Found 0 performance improvements and 0 performance regressions! Performance is the same for 221 metrics, 9 unstable metrics.
Codecov Report
Attention: Patch coverage is 18.51852% with 44 lines in your changes missing coverage. Please review.
Project coverage is 10.42%. Comparing base (
8823cac) to head (2e39d58). Report is 6 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@
## main #9705 +/- ##
===========================================
- Coverage 74.48% 10.42% -64.07%
===========================================
Files 1390 1358 -32
Lines 128765 126612 -2153
===========================================
- Hits 95908 13196 -82712
- Misses 32857 113416 +80559
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Moved to draft to add some processor tests.
Added a test checking that the correct WAF addresses are called, PTAL @erikayasuda.