dd-trace-py
dd-trace-py copied to clipboard
chore(auto-inject): add package instrumentation skipping and denylist
Checklist
- [x] Change(s) are motivated and described in the PR description
- [x] Testing strategy is described if automated tests are not included in the PR
- [x] Risks are described (performance impact, potential for breakage, maintainability)
- [x] Change is maintainable (easy to change, telemetry, documentation)
- [x] Library release note guidelines are followed or label
changelog/no-changelogis set - [x] Documentation is included (in-code, generated user docs, public corp docs)
- [x] Backport labels are set (if applicable)
- [x] If this PR changes the public interface, I've notified
@DataDog/apm-tees.
Reviewer Checklist
- [ ] Title is accurate
- [ ] All changes are related to the pull request's stated goal
- [ ] Description motivates each change
- [ ] Avoids breaking API changes
- [ ] Testing strategy adequately addresses listed risks
- [ ] Change is maintainable (easy to change, telemetry, documentation)
- [ ] Release note makes sense to a user of the library
- [ ] Author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
- [ ] Backport labels are set in a manner that is consistent with the release branch maintenance policy
Datadog Report
Branch report: zachg/fix_lib_injection_integration_bailing_and_add_default_path
Commit report: f6ecccd
Test service: dd-trace-py
:white_check_mark: 0 Failed, 8459 Passed, 14412 Skipped, 1h 58m 14.07s Total duration (6.17s time saved)
Benchmarks
Benchmark execution time: 2024-11-08 20:25:29
Comparing candidate commit cf4069d4653afcd1012b58473543ac0c442cbf25 in PR branch zachg/fix_lib_injection_integration_bailing_and_add_default_path with baseline commit 62727981a6fd702a6fd48f0f35e581aec36ede4f in branch main.
Found 1 performance improvements and 0 performance regressions! Performance is the same for 387 metrics, 2 unstable metrics.
scenario:iast_aspects-replace_aspect
- 🟩
execution_time[-638.573ns; -564.497ns] or [-8.840%; -7.815%]
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 10.54%. Comparing base (
9cce458) to head (3686896). Report is 4 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@
## main #9685 +/- ##
===========================================
- Coverage 73.93% 10.54% -63.39%
===========================================
Files 1402 1368 -34
Lines 130420 127984 -2436
===========================================
- Hits 96426 13502 -82924
- Misses 33994 114482 +80488
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
CODEOWNERS have been resolved as:
lib-injection/sources/sitecustomize.py @DataDog/apm-core-python