dd-trace-py
dd-trace-py copied to clipboard
fix(langchain): addresses compatibility issues with langchains vision API
Fixes #8149
Checklist
- [x] Change(s) are motivated and described in the PR description
- [x] Testing strategy is described if automated tests are not included in the PR
- [x] Risks are described (performance impact, potential for breakage, maintainability)
- [x] Change is maintainable (easy to change, telemetry, documentation)
- [x] Library release note guidelines are followed or label
changelog/no-changelog
is set - [x] Documentation is included (in-code, generated user docs, public corp docs)
- [ ] Backport labels are set (if applicable)
- [x] If this PR changes the public interface, I've notified
@DataDog/apm-tees
. - [x] If change touches code that signs or publishes builds or packages, or handles credentials of any kind, I've requested a review from
@DataDog/security-design-and-guidance
.
Reviewer Checklist
- [ ] Title is accurate
- [ ] All changes are related to the pull request's stated goal
- [ ] Description motivates each change
- [ ] Avoids breaking API changes
- [ ] Testing strategy adequately addresses listed risks
- [ ] Change is maintainable (easy to change, telemetry, documentation)
- [ ] Release note makes sense to a user of the library
- [ ] Author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
- [ ] Backport labels are set in a manner that is consistent with the release branch maintenance policy
https://github.com/DataDog/dd-trace-py/issues/8149#issuecomment-1995858906
It looks like the langchain version that is being used by dd-trace-py is quite old: langchain==0.0.192
This issue is happening on later versions of Langchain - langchain==0.0.339
@mabdinur , @Yun-Kim - Thank you so much for picking this up. Really appreciate it.
The backport to 2.6
failed:
The process '/usr/bin/git' failed with exit code 1
To backport manually, run these commands in your terminal:
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.6 2.6
# Navigate to the new working tree
cd .worktrees/backport-2.6
# Create a new branch
git switch --create backport-8681-to-2.6
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 92e2dc3285b8b860a3339ea609b0b2e4b7085047
# Push it to GitHub
git push --set-upstream origin backport-8681-to-2.6
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.6
Then, create a pull request where the base
branch is 2.6
and the compare
/head
branch is backport-8681-to-2.6
.
The backport to 2.7
failed:
The process '/usr/bin/git' failed with exit code 1
To backport manually, run these commands in your terminal:
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.7 2.7
# Navigate to the new working tree
cd .worktrees/backport-2.7
# Create a new branch
git switch --create backport-8681-to-2.7
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 92e2dc3285b8b860a3339ea609b0b2e4b7085047
# Push it to GitHub
git push --set-upstream origin backport-8681-to-2.7
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.7
Then, create a pull request where the base
branch is 2.7
and the compare
/head
branch is backport-8681-to-2.7
.