dd-trace-py icon indicating copy to clipboard operation
dd-trace-py copied to clipboard

ci: pin sqlalchemy for starlette tests

Open gnufede opened this issue 1 year ago • 1 comments
trafficstars

ci: pin sqlalchemy for starlette tests

Checklist

  • [x] Change(s) are motivated and described in the PR description
  • [x] Testing strategy is described if automated tests are not included in the PR
  • [x] Risks are described (performance impact, potential for breakage, maintainability)
  • [x] Change is maintainable (easy to change, telemetry, documentation)
  • [x] Library release note guidelines are followed or label changelog/no-changelog is set
  • [x] Documentation is included (in-code, generated user docs, public corp docs)
  • [x] Backport labels are set (if applicable)
  • [x] If this PR changes the public interface, I've notified @DataDog/apm-tees.
  • [x] If change touches code that signs or publishes builds or packages, or handles credentials of any kind, I've requested a review from @DataDog/security-design-and-guidance.

Reviewer Checklist

  • [ ] Title is accurate
  • [ ] All changes are related to the pull request's stated goal
  • [ ] Description motivates each change
  • [ ] Avoids breaking API changes
  • [ ] Testing strategy adequately addresses listed risks
  • [ ] Change is maintainable (easy to change, telemetry, documentation)
  • [ ] Release note makes sense to a user of the library
  • [ ] Author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • [ ] Backport labels are set in a manner that is consistent with the release branch maintenance policy

gnufede avatar Mar 04 '24 17:03 gnufede

Benchmarks

Benchmark execution time: 2024-03-22 18:44:57

Comparing candidate commit bc2a32ea857f90a6c90c6aa386e79b337b1c410f in PR branch gnufede/pin-sqlalchemy-starlette with baseline commit d1d16829e272a983f2f95208c333ed04ad62e608 in branch main.

Found 6 performance improvements and 2 performance regressions! Performance is the same for 193 metrics, 9 unstable metrics.

scenario:httppropagationextract-all_styles_all_headers

  • 🟩 max_rss_usage [-633.315KB; -440.657KB] or [-2.906%; -2.022%]

scenario:httppropagationextract-large_header_no_matches

  • 🟥 max_rss_usage [+635.005KB; +712.169KB] or [+2.991%; +3.355%]

scenario:httppropagationextract-medium_header_no_matches

  • 🟥 max_rss_usage [+647.090KB; +725.070KB] or [+3.053%; +3.421%]

scenario:httppropagationextract-valid_headers_all

  • 🟩 max_rss_usage [-787.336KB; -609.400KB] or [-3.599%; -2.786%]

scenario:sethttpmeta-no-collectipvariant

  • 🟩 max_rss_usage [-753.337KB; -507.002KB] or [-3.421%; -2.302%]

scenario:sethttpmeta-obfuscation-no-query

  • 🟩 max_rss_usage [-764.343KB; -507.055KB] or [-3.459%; -2.295%]

scenario:sethttpmeta-useragentvariant_exists_2

  • 🟩 max_rss_usage [-755.078KB; -459.796KB] or [-3.414%; -2.079%]

scenario:sethttpmeta-useragentvariant_exists_3

  • 🟩 max_rss_usage [-732.280KB; -510.447KB] or [-3.308%; -2.306%]

pr-commenter[bot] avatar Mar 04 '24 18:03 pr-commenter[bot]