dd-trace-py icon indicating copy to clipboard operation
dd-trace-py copied to clipboard

chore(profiling): add at least some tests for stack v2

Open sanchda opened this issue 11 months ago • 2 comments

Checklist

  • [ ] Change(s) are motivated and described in the PR description
  • [ ] Testing strategy is described if automated tests are not included in the PR
  • [ ] Risks are described (performance impact, potential for breakage, maintainability)
  • [ ] Change is maintainable (easy to change, telemetry, documentation)
  • [ ] Library release note guidelines are followed or label changelog/no-changelog is set
  • [ ] Documentation is included (in-code, generated user docs, public corp docs)
  • [ ] Backport labels are set (if applicable)
  • [ ] If this PR changes the public interface, I've notified @DataDog/apm-tees.
  • [ ] If change touches code that signs or publishes builds or packages, or handles credentials of any kind, I've requested a review from @DataDog/security-design-and-guidance.

Reviewer Checklist

  • [ ] Title is accurate
  • [ ] All changes are related to the pull request's stated goal
  • [ ] Description motivates each change
  • [ ] Avoids breaking API changes
  • [ ] Testing strategy adequately addresses listed risks
  • [ ] Change is maintainable (easy to change, telemetry, documentation)
  • [ ] Release note makes sense to a user of the library
  • [ ] Author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • [ ] Backport labels are set in a manner that is consistent with the release branch maintenance policy

sanchda avatar Mar 02 '24 03:03 sanchda

Datadog Report

Branch report: sanchda/stackv2_initial_tests Commit report: 1e4af8d Test service: dd-trace-py

:white_check_mark: 0 Failed, 171240 Passed, 1073 Skipped, 11h 50m 8.84s Total duration (33.67s time saved)

Benchmarks

Benchmark execution time: 2024-04-01 17:19:11

Comparing candidate commit 368aa742768099b1521af1003fde1d2454d8d210 in PR branch sanchda/stackv2_initial_tests with baseline commit bf295752c3ae578b347a9d7a467ccd54066af063 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 201 metrics, 9 unstable metrics.

pr-commenter[bot] avatar Mar 02 '24 04:03 pr-commenter[bot]

Datadog Report

Branch report: sanchda/stackv2_initial_tests Commit report: 13743c9 Test service: dd-trace-py

:white_check_mark: 0 Failed, 171726 Passed, 1057 Skipped, 11h 28m 21.22s Total duration (39m 21.21s time saved)