dd-trace-py icon indicating copy to clipboard operation
dd-trace-py copied to clipboard

experimental

Open duncanista opened this issue 1 year ago • 1 comments

jordan.gonzalez experimental branch

Checklist

  • [ ] Change(s) are motivated and described in the PR description
  • [ ] Testing strategy is described if automated tests are not included in the PR
  • [ ] Risks are described (performance impact, potential for breakage, maintainability)
  • [ ] Change is maintainable (easy to change, telemetry, documentation)
  • [ ] Library release note guidelines are followed or label changelog/no-changelog is set
  • [ ] Documentation is included (in-code, generated user docs, public corp docs)
  • [ ] Backport labels are set (if applicable)
  • [ ] If this PR changes the public interface, I've notified @DataDog/apm-tees.
  • [ ] If change touches code that signs or publishes builds or packages, or handles credentials of any kind, I've requested a review from @DataDog/security-design-and-guidance.

Reviewer Checklist

  • [ ] Title is accurate
  • [ ] All changes are related to the pull request's stated goal
  • [ ] Description motivates each change
  • [ ] Avoids breaking API changes
  • [ ] Testing strategy adequately addresses listed risks
  • [ ] Change is maintainable (easy to change, telemetry, documentation)
  • [ ] Release note makes sense to a user of the library
  • [ ] Author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • [ ] Backport labels are set in a manner that is consistent with the release branch maintenance policy

duncanista avatar Feb 05 '24 21:02 duncanista

Benchmarks

Benchmark execution time: 2024-04-16 16:29:05

Comparing candidate commit 31b439187d913bd21ab796c177db1113d161fe96 in PR branch jordan.gonzalez/experimental with baseline commit bafded380ab90b0db25530dc148a20c2e3a20871 in branch main.

Found 2 performance improvements and 1 performance regressions! Performance is the same for 198 metrics, 9 unstable metrics.

scenario:httppropagationextract-datadog_tracecontext_tracestate_not_propagated_on_trace_id_no_match

  • 🟥 max_rss_usage [+673.979KB; +750.609KB] or [+3.182%; +3.544%]

scenario:otelspan-start-finish

  • 🟩 max_rss_usage [-772.760KB; -695.656KB] or [-3.331%; -2.999%]

scenario:otelspan-start-finish-telemetry

  • 🟩 max_rss_usage [-740.870KB; -659.552KB] or [-3.197%; -2.846%]

pr-commenter[bot] avatar Feb 06 '24 16:02 pr-commenter[bot]