dd-trace-py icon indicating copy to clipboard operation
dd-trace-py copied to clipboard

fix(pytest): add freezegun exception

Open ericlaz opened this issue 2 years ago โ€ข 1 comments

CIVIS-7770

Checklist

  • [ ] Change(s) are motivated and described in the PR description.
  • [ ] Testing strategy is described if automated tests are not included in the PR.
  • [ ] Risk is outlined (performance impact, potential for breakage, maintainability, etc).
  • [ ] Change is maintainable (easy to change, telemetry, documentation).
  • [ ] Library release note guidelines are followed. If no release note is required, add label changelog/no-changelog.
  • [ ] Documentation is included (in-code, generated user docs, public corp docs).
  • [ ] Backport labels are set (if applicable)

Reviewer Checklist

  • [ ] Title is accurate.
  • [ ] No unnecessary changes are introduced.
  • [ ] Description motivates each change.
  • [ ] Avoids breaking API changes unless absolutely necessary.
  • [ ] Testing strategy adequately addresses listed risk(s).
  • [ ] Change is maintainable (easy to change, telemetry, documentation).
  • [ ] Release note makes sense to a user of the library.
  • [ ] Reviewer has explicitly acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment.
  • [ ] Backport labels are set in a manner that is consistent with the release branch maintenance policy
  • [ ] If this PR touches code that signs or publishes builds or packages, or handles credentials of any kind, I've requested a review from @DataDog/security-design-and-guidance.
  • [ ] This PR doesn't touch any of that.

ericlaz avatar Nov 28 '23 13:11 ericlaz

Benchmarks

Benchmark execution time: 2023-12-11 11:43:01

Comparing candidate commit 68ec1c300cf35c54aab0885a283649a9e95f7432 in PR branch eric.navarro/add-freezegun-exception with baseline commit fe2cc31f2edd43c14282c430281d00866e09a151 in branch main.

Found 11 performance improvements and 14 performance regressions! Performance is the same for 170 metrics, 9 unstable metrics.

scenario:coreapiscenario-context_with_data_no_listeners

  • ๐ŸŸฉ max_rss_usage [-828.045KB; -679.283KB] or [-2.852%; -2.340%]

scenario:coreapiscenario-context_with_data_only_all_listeners

  • ๐ŸŸฉ max_rss_usage [-885.762KB; -738.302KB] or [-3.045%; -2.538%]

scenario:coreapiscenario-core_dispatch_only_all_listeners

  • ๐ŸŸฉ max_rss_usage [-837.659KB; -668.850KB] or [-2.882%; -2.301%]

scenario:coreapiscenario-core_dispatch_with_results_listeners

  • ๐ŸŸฉ max_rss_usage [-801.109KB; -668.126KB] or [-2.756%; -2.299%]

scenario:coreapiscenario-core_dispatch_with_results_no_listeners

  • ๐ŸŸฅ max_rss_usage [+589.023KB; +766.753KB] or [+2.079%; +2.707%]

scenario:coreapiscenario-set_item

  • ๐ŸŸฅ max_rss_usage [+622.161KB; +776.214KB] or [+2.194%; +2.738%]

scenario:flasksimple-tracer

  • ๐ŸŸฉ execution_time [-1053.899ยตs; -889.911ยตs] or [-8.035%; -6.785%]

scenario:httppropagationextract-b3_single_headers

  • ๐ŸŸฅ max_rss_usage [+687.678KB; +924.508KB] or [+2.427%; +3.263%]

scenario:httppropagationextract-full_t_id_datadog_headers

  • ๐ŸŸฉ max_rss_usage [-844.329KB; -620.401KB] or [-2.894%; -2.127%]

scenario:httppropagationextract-invalid_trace_id_header

  • ๐ŸŸฅ max_rss_usage [+1.008MB; +1.209MB] or [+3.600%; +4.317%]

scenario:httppropagationextract-large_valid_headers_all

  • ๐ŸŸฅ max_rss_usage [+601.092KB; +784.995KB] or [+2.116%; +2.763%]

scenario:httppropagationextract-valid_headers_basic

  • ๐ŸŸฅ max_rss_usage [+700.526KB; +870.290KB] or [+2.464%; +3.061%]

scenario:httppropagationextract-wsgi_valid_headers_all

  • ๐ŸŸฅ max_rss_usage [+748.702KB; +922.876KB] or [+2.639%; +3.253%]

scenario:httppropagationinject-ids_only

  • ๐ŸŸฉ max_rss_usage [-807.933KB; -676.867KB] or [-2.777%; -2.327%]

scenario:httppropagationinject-with_priority_and_origin

  • ๐ŸŸฅ max_rss_usage [+578.870KB; +756.836KB] or [+2.042%; +2.670%]

scenario:httppropagationinject-with_tags_max_size

  • ๐ŸŸฅ max_rss_usage [+717.633KB; +849.906KB] or [+2.526%; +2.992%]

scenario:otelspan-start-finish-telemetry

  • ๐ŸŸฅ max_rss_usage [+656.643KB; +799.075KB] or [+2.224%; +2.707%]

scenario:sethttpmeta-all-disabled

  • ๐ŸŸฅ max_rss_usage [+643.421KB; +813.117KB] or [+2.009%; +2.539%]

scenario:sethttpmeta-all-enabled

  • ๐ŸŸฅ max_rss_usage [+709.311KB; +848.807KB] or [+2.214%; +2.650%]

scenario:sethttpmeta-useragentvariant_exists_2

  • ๐ŸŸฅ max_rss_usage [+714.907KB; +865.330KB] or [+2.237%; +2.708%]

scenario:sethttpmeta-useragentvariant_exists_3

  • ๐ŸŸฅ max_rss_usage [+681.945KB; +882.318KB] or [+2.134%; +2.761%]

scenario:span-start-finish-telemetry

  • ๐ŸŸฉ max_rss_usage [-805.418KB; -681.430KB] or [-2.769%; -2.342%]

scenario:span-start-finish-traceid128

  • ๐ŸŸฉ max_rss_usage [-796.388KB; -654.415KB] or [-2.737%; -2.249%]

scenario:tracer-large

  • ๐ŸŸฉ max_rss_usage [-1.197MB; -1.050MB] or [-3.994%; -3.504%]

scenario:tracer-small

  • ๐ŸŸฉ max_rss_usage [-1035.016KB; -896.248KB] or [-3.561%; -3.083%]

pr-commenter[bot] avatar Nov 28 '23 14:11 pr-commenter[bot]